Fix: Multiple Choice fixes for hidden / deleted states

[ncarazon]

Resolves #4818

Summary

Deleted options in multiple choice questions were still displaying forecast percentages, and CP values were still visible in the legend even when CP was hidden by the user.

Implemented changes:

• Deleted options: tracked isDeleted flag on ChoiceItem and suppressed the forecast percentage in the legend for deleted options
• Hidden CP: wired the hideCP flag through all three chart render paths so percentages are hidden in the legend when CP is hidden

Demo videos

Before

fix-mc-hidden-deleted-states-before.mp4

After

fix-mc-hidden-deleted-states-after.mp4

Summary by CodeRabbit

Release Notes

• New Features

  • Added ability to hide forecast/confidence point values in multiple choice chart legend display.

• Improvements

  • Enhanced system to track deletion state of choices for better data integrity in choice item representation.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4d10cb29-1e9a-4fde-ba62-c2f573569543

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/mc-hidden-deleted-states

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Preview Environment

Your preview environment is ready!

Resource	Details
🌐 Preview URL	https://metaculus-pr-4828-fix-mc-hidden-deleted-states-preview.mtcl.cc
📦 Docker Image	ghcr.io/metaculus/metaculus:fix-mc-hidden-deleted-states-86d54fb
🗄️ PostgreSQL	NeonDB branch preview/pr-4828-fix-mc-hidden-deleted-states
⚡ Redis	Fly Redis mtc-redis-pr-4828-fix-mc-hidden-deleted-states

Details

• Commit: 902593c807468c929a8dbc800028d0c4035117eb
• Branch: fix/mc-hidden-deleted-states
• Fly App: metaculus-pr-4828-fix-mc-hidden-deleted-states

---

ℹ️ Preview Environment Info

Isolation:

• PostgreSQL and Redis are fully isolated from production
• Each PR gets its own database branch and Redis instance
• Changes pushed to this PR will trigger a new deployment

Limitations:

• Background workers and cron jobs are not deployed in preview environments
• If you need to test background jobs, use Heroku staging environments

Cleanup:

• This preview will be automatically destroyed when the PR is closed