Fix markdown parsing for code blocks when withCodeBlocks is false#4804
Draft
SylvainChevalier wants to merge 1 commit into
Draft
Fix markdown parsing for code blocks when withCodeBlocks is false#4804SylvainChevalier wants to merge 1 commit into
SylvainChevalier wants to merge 1 commit into
Conversation
… is off
The post background-information / notebook markdown / group description
fields render MarkdownEditor without withCodeBlocks, but content authored
elsewhere may still contain ``` fences. With no codeBlockPlugin
registered, MDXEditor throws "Parsing of the following markdown structure
failed: {type: code, name: N/A}".
Always register codeBlockPlugin with the read-only Prism descriptor so
existing fences parse; withCodeBlocks now only gates the insert-code-block
toolbar affordance and the rich CodeMirror editing path.
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue where MDXEditor would throw a parsing error when encountering code blocks (``` fences) in markdown content when the
withCodeBlocksprop is set to `false`. The code block plugin is now always registered to handle parsing of existing code blocks, while the `withCodeBlocks` flag continues to control only the UI affordances (toolbar button and rich editing experience).Key Changes
InitializedMarkdownEditorto always include thecodeBlockPlugin, regardless of thewithCodeBlockssettingwithCodeBlocksflag now only gates the insert-code-block toolbar affordance and the CodeMirror editing experience, not the parsing of existing code blockswithCodeBlocksis falseImplementation Details
!withCodeBlocks || mode === "read"instead of returning early whenwithCodeBlocksis falsehttps://claude.ai/code/session_01PZkycszwECr7vMhFzQKf56