Skip to content

System Hooks#1959

Open
JPMeehan wants to merge 2 commits into
1.1.xfrom
1941-ability-dialog-hook
Open

System Hooks#1959
JPMeehan wants to merge 2 commits into
1.1.xfrom
1941-ability-dialog-hook

Conversation

@JPMeehan

@JPMeehan JPMeehan commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Closes #1941

@JPMeehan JPMeehan added this to the v1.1.0 milestone Jul 1, 2026
@JPMeehan JPMeehan requested a review from krbz999 July 1, 2026 15:38
@JPMeehan JPMeehan self-assigned this Jul 1, 2026
@JPMeehan JPMeehan added the documentation Improvements or additions to documentation label Jul 1, 2026
Comment thread src/docs/Hooks.md Outdated
Comment thread src/module/applications/apps/ability-configuration-dialog.mjs Outdated
Comment thread src/docs/Hooks.md Outdated
@JPMeehan JPMeehan requested a review from krbz999 July 3, 2026 13:36
Comment thread src/docs/Hooks.md

## Prepare Data

The ActiveEffect, Actor, ChatMessage, Combat, Combatant, Item, and User documents all have a hook of the format `ds.prepare${DocumentName}Data`. This hook is called after all other data preparation has completed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have been clearer. What I meant was that, since the result of this hook could be achieved with an AE anyway, like the omitted sentence implied, I think we should neglect to document this hook until such a time that we decide that it is actually worth keeping.

At the moment, there are no modules making use of it to my knowledge.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah I added it because my experience with SWADE & dnd5e is you sometimes just need to do stuff in data prep, in a way that is sometimes simplified by combination with flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System Hook: ds.preRenderAbilityConfigurationDialog

2 participants