Skip to content

[#509] Implemented Potency Check Method#1909

Open
JPMeehan wants to merge 11 commits into
1.1.xfrom
1869-potency-results
Open

[#509] Implemented Potency Check Method#1909
JPMeehan wants to merge 11 commits into
1.1.xfrom
1869-potency-results

Conversation

@JPMeehan

@JPMeehan JPMeehan commented May 20, 2026

Copy link
Copy Markdown
Contributor

Hovering over a potency enricher inside an ability result highlights affected targets in green. Also adds chr.resist as a data field for handling when a characteristic should be treated as lower/higher for potency purposes. Does not implement spending surges to increase effective potency, leaving that feature for a follow-up PR

image

Closes #509

@JPMeehan JPMeehan added this to the v1.1.0 milestone May 20, 2026
@JPMeehan JPMeehan requested a review from krbz999 May 20, 2026 03:56
@JPMeehan JPMeehan self-assigned this May 20, 2026
@JPMeehan JPMeehan added the apps Sheet and App issues label May 20, 2026
Comment thread src/module/data/actor/creature.mjs Outdated

@krbz999 krbz999 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you got an ability to test this with?

Comment thread src/module/data/actor/creature.mjs
Comment thread src/module/data/pseudo-documents/power-roll-effects/base-power-roll-effect.mjs Outdated
Comment thread src/module/documents/actor.mjs
@JPMeehan

Copy link
Copy Markdown
Contributor Author

We've got a lot of abilities with potencies already set up, but just for the two examples

"Concussive Strike" (level 1 Tactician 3 Focus ability) as part of a power roll effect

"To Me Squad!" (level 6 Tactician 9 Focus ability) where it's an enricher in the descriptive text

@krbz999 krbz999 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it took me a good minute or more to figure out what I was actually meant to be seeing here.

This just seems incredibly redundant and near-useless with how difficult it is to even find, given the size of this feature itself which doesn't really do much.

I think this is something we should just leave for the eventual chat message overhaul. That way we also don't have to carry forward a bunch of features that we're likely to forget about.

There are some fine changes here for the data but the UI changes are unnecessary bloat.

@JPMeehan

JPMeehan commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

So, basically just do 509 and add resist as a key + the function to evaluate?

@krbz999 krbz999 force-pushed the 1869-potency-results branch from 72e8014 to b63d6ff Compare June 12, 2026 12:27
@JPMeehan JPMeehan changed the title [#509, #1869] Implemented Potency Display [#509] Implemented Potency Check Method Jun 20, 2026
@JPMeehan JPMeehan requested a review from krbz999 June 22, 2026 21:28
@JPMeehan

JPMeehan commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@krbz999 could use another review here

@krbz999

krbz999 commented Jul 7, 2026

Copy link
Copy Markdown
Member
image

@JPMeehan

JPMeehan commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@krbz999 was previously fixed issue that didn't have the fix merged into this branch; this PR is now API only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apps Sheet and App issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Potency Resistance

3 participants