Updates for discworld core by jalensailin · Pull Request #28 · MetaMorphic-Digital/discworld-modiphius

jalensailin · 2026-07-08T07:13:37Z

This MR does the following:

Adds some things that were originally going to go into the core module:
- Adds direct support for new Trait types, filtered by actorType
- Adds a new data point to the Trait schema (actorType)
Adds alt attributes / tooltips for document images

krbz999

Generally I'm a little confused by the underlying ideas here.

krbz999 · 2026-07-08T12:27:08Z

  <div class="portrait-container">
-    <img class="portrait" src="{{document.img}}" data-edit="img" data-action="editImage" title="{{document.name}}"
-      alt="">
+    <img class="portrait" src="{{document.img}}" data-edit="img" data-action="editImage" data-tooltip="{{document.name}}"


Suggested change

<img class="portrait" src="{{document.img}}" data-edit="img" data-action="editImage" data-tooltip="{{document.name}}"

<img class="portrait" src="{{document.img}}" data-edit="img" data-action="editImage" data-tooltip-text="{{document.name}}"

Addressed in recent commit

krbz999 · 2026-07-08T12:27:22Z

      data-edit="img"
      data-action="editImage"
-      title="{{document.name}}">
+      data-tooltip="{{document.name}}"


Suggested change

data-tooltip="{{document.name}}"

data-tooltip-text="{{document.name}}"

Addressed in recent commit

krbz999 · 2026-07-08T12:28:19Z


  <div class="header-data-container flexcol">
-    <h1 class="document-name">{{formInput fields.name.field value=fields.name.value}}</h1>
+    <h1 class="document-name">{{formInput fields.name.field value=fields.name.value rootId=document.id}}</h1>


This rootId is not unique. Should use the application's id, but it may be that rootId is already in the context if it's DocumentSheet.

Fixed in recent commit

krbz999 · 2026-07-08T12:30:17Z

      severity: new StringField({ required: true, initial: "minor", choices: DISCWORLD.consequenceSeverity }),
-      type: new StringField({ required: true, choices: () => DISCWORLD.traitTypes, initial: "consequences" }),
+      type: new StringField({
+        required: true, choices: traitTypeChoices, initial: "consequences",


Shouldn't have choices here at all if a module can extend it. It would lead to the actor/item becoming invalid when the module is disabled.

Instead, remove choices here. Prepare the choices in the sheet's context preparation. If the current value is truthy and not one of the options, add it as an additional option with value === label.

I don't fully understand your instruction here. Is something like this what you mean?

prepareContext() { ... const { traitTypes } = discworld.config; let typeChoices = traitTypes[system.actorType] ?? traitTypes.character; if (!Object.keys(typeChoices).includes(system.type) && system.type) { typeChoices = foundry.utils.mergeObject( typeChoices, { [system.type]: _loc(`DISCWORLD.trait.type.${system.type}`) }, { inplace: false }, ); } context.fields.type.choices = typeChoices; ... } // Got rid of this override: // _onRender() { // }

And then in the form group:

{{formGroup fields.type.field value=fields.type.value choices=fields.type.choices rootId=rootId}}

krbz999 · 2026-07-08T12:31:36Z

+      const [defaultType] = Object.keys(discworld.config.traitTypes[target.value]);
+      this.document.update(
+        { "system.type": defaultType },
+        { render: false },


Not sure I understand what's going on here. This seems like a workaround for something?

When actorType is changed, the set of available trait types change. This sets the trait type to an allowed default for a particular actorType when it is changed

krbz999 · 2026-07-08T12:32:20Z

+    await super._onRender(context, options);
+
+    const { system } = this.document;
+
+    // Sort and filter <option> elements.
+    const validTraits = Object.keys(discworld.config.traitTypes[system.actorType]);
+    const select = this.element.querySelector("select[name=\"system.type\"]");
+    const optionElements = Array.from(select.querySelectorAll("option"));
+
+    optionElements
+      .sort((a, b) => validTraits.indexOf(a.value) - validTraits.indexOf(b.value))
+      .forEach((option) => {
+        if (!validTraits.includes(option.value)) {
+          option.remove();
+        } else {
+          select.appendChild(option);
+        }
+      });
+  }


This should all just be in context prep.

krbz999 · 2026-07-08T12:35:02Z

+   * @type {string}
+   */
+  get actorBaseType() {
+    return this.actor.type.replace(/.*\./, "");


Doesn't seem necessary to me. Can you explain the logic behind this and the link between it and DISCWORLD.traitTypes?

actorType filters the available options for traitTypes, so that npcs and characters each get their own set of traits types.

This particular method just gets the base actor type without the discworld-core, so that storage/retrieval is simpler (i.e., not having to store/retrieve a cumbersome id like this, discworld-core.npc).

jalensailin added 2 commits July 8, 2026 03:11

Add support for new Actor types and Trait types;

04b7ac9

Add alt attribute to document images

f76816d

jalensailin requested a review from krbz999 July 8, 2026 07:16

jalensailin self-assigned this Jul 8, 2026

jalensailin added the compatibility Related to compatibility with a module or Foundry version label Jul 8, 2026

krbz999 requested changes Jul 8, 2026

View reviewed changes

	<img class="portrait" src="{{document.img}}" data-edit="img" data-action="editImage" data-tooltip="{{document.name}}"
	<img class="portrait" src="{{document.img}}" data-edit="img" data-action="editImage" data-tooltip-text="{{document.name}}"

	data-tooltip="{{document.name}}"
	data-tooltip-text="{{document.name}}"

Uh oh!

Conversation

jalensailin commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krbz999 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jalensailin commented Jul 8, 2026 •

edited

Loading