refactor!: remove gatsby#181
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
43e0af3 to
6ab1be1
Compare
| env: | ||
| GATSBY_PATH_PREFIX: ${{ github.event.repository.name }}/${{ inputs.destination_dir }}/ | ||
| SNAP_ORIGIN: npm:@metamask/${{ github.event.repository.name }}-snap | ||
| PATH_PREFIX: ${{ github.event.repository.name }}/${{ inputs.destination_dir }}/ |
There was a problem hiding this comment.
Now used by webpack! See webpack.config.js
| "dependencies": { | ||
| "@emotion/react": "^11.11.1", | ||
| "@emotion/styled": "^11.11.0", | ||
| "@metamask/keyring-api": "^23.1.0", | ||
| "@metamask/keyring-snap-client": "^9.0.2", | ||
| "@metamask/providers": "^19.0.0", | ||
| "@mui/icons-material": "^5.14.0", | ||
| "@mui/material": "^5.14.0", | ||
| "@types/react-helmet": "^6.1.6", | ||
| "crypto-browserify": "^3.12.1", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-helmet": "^6.1.0", | ||
| "react-icons": "^4.8.0", | ||
| "react-is": "^18.2.0", | ||
| "semver": "^7.5.4", | ||
| "styled-components": "5.3.9", | ||
| "webpack": "^5.88.2" | ||
| }, |
There was a problem hiding this comment.
Moved all dependencies as devDependencies so they do not interfere with the main dep tree (the extension is using the dapp dependency to use it in its e2e tests).
That's ok given that we mostly build a bundle/static code that will be then served. No need to have any actual runtime dep for this.
|
Warning MetaMask internal reviewing guidelines:
Ignoring alerts on:
|
|
@SocketSecurity ignore npm/commander@10.0.1 I think that's a false-positive, there's no actual obfuscated code in there. Also, double-checked the actual code, and everything look legit to me. |
|
@SocketSecurity ignore npm/copy-webpack-plugin@11.0.0 Looks legit too, this package uses |
95f988c to
2f6f89d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b77791d. Configure here.

Trying to simplify the SSK site as much as we can to align with other test dapps we have.
Note
Medium Risk
Large build and UI refactor with CI publishing
dist/and renamed env vars; breakage would mainly affect the dev test site and e2e flows rather than production snap logic.Overview
Replaces the Simple Snap Keyring site’s Gatsby stack with a Webpack 5 + SWC SPA that builds to
dist/instead ofpublic/, matching other MetaMask test dapps.The Gatsby config, page routing, and MUI/styled-components UI are removed in favor of
index.html+index.tsx, Bootstrap styling, and a singleApp.tsxthat inlines connect, accounts, options, and keyring RPC test forms. Snap targeting now usesSNAP_ORIGINandPATH_PREFIX(injected at build time via Webpack’sEnvironmentPlugin) instead ofGATSBY_*/.env.productionwrites.GitHub Actions publish the new output directory and pass build env vars directly in the dapp workflow; release caches no longer include
packages/*/public. MetaMask access goes throughgetEthereumProvider()with optionalwindow.ethereumtyping, and the snap manifest shasum is updated for the bundled snap.Reviewed by Cursor Bugbot for commit b09ed59. Bugbot is set up for automated code reviews on this repo. Configure here.