ci: request workflows:write for crowdin translation token exchange cp-8.3.0#33403
Open
tommasini wants to merge 1 commit into
Open
ci: request workflows:write for crowdin translation token exchange cp-8.3.0#33403tommasini wants to merge 1 commit into
tommasini wants to merge 1 commit into
Conversation
Both crowdin_download_translations.yml and crowdin-rc-download-translations.yml
push brand-new l10n branches via installation tokens, the same pattern that
caused create-release-pr.yml / update-release-changelog.yml to hit GitHub's
push-protection timeout ("Unable to determine if workflow can be created or
updated due to timeout; workflows scope may be required"). Requesting
workflows:write avoids the slow dynamic check on new-branch pushes.
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamask-ci
Bot
added
team-mobile-platform
Contributor
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
tommasini
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the fix from #33352 to the two Crowdin translation workflows that share the same new-branch-push pattern:
crowdin_download_translations.ymlcrowdin-rc-download-translations.ymlBoth mint an installation token via the token-exchange service and push a brand-new l10n branch (
l10n_crowdin_translations_*) to open a translations PR. This is the exact pattern that causedcreate-release-pr.ymlandupdate-release-changelog.ymlto intermittently fail with:GitHub performs a slow, dynamic push-protection check on new-branch pushes when the pushing token lacks the
workflowsscope, and that check occasionally times out on this monorepo. Pre-grantingworkflows: writeon the minted token avoids the slow path entirely, even though these steps never touch.github/workflows/*.Dependency
workflows: writefor these two workflows, the same way it was updated forcreate-release-pr.yml/update-release-changelog.yml. A policy-update prompt is included below for whoever owns that repo.https://github.com/consensys-vertical-apps/token-exchange-service/pull/143
Test plan
ruby -ryaml -e "YAML.load_file(...)"passed locally for both files)workflows: writeto these two workflowscrowdin_download_translations.ymlandcrowdin-rc-download-translations.ymlmanually (workflow_dispatch) and confirm the translations PR/branch push succeeds without the timeout errorMade with Cursor