Skip to content

fix: Bump react-data-query#33402

Merged
FrederikBolding merged 1 commit into
mainfrom
fb/react-data-query-bug-fix
Jul 16, 2026
Merged

fix: Bump react-data-query#33402
FrederikBolding merged 1 commit into
mainfrom
fb/react-data-query-bug-fix

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Jul 16, 2026

Copy link
Copy Markdown
Member

Description

Bump metamask/react-data-query to the latest version fixing a bug where queries would be deleted from cache prematurely.

Changelog

CHANGELOG entry: Fixed an issue where certain UI elements would flicker

Related issues

https://consensyssoftware.atlassian.net/browse/WPC-1168


Note

Low Risk
Lockfile-only dependency upgrade with no application code changes; behavior change is limited to query caching in hooks that already use @metamask/react-data-query.

Overview
Bumps @metamask/react-data-query from ^0.2.0 to ^0.2.2 in package.json and refreshes yarn.lock. There are no app source changes—only the dependency pin.

The newer release fixes premature removal of queries from the TanStack Query cache, which was causing some UI to flicker when data was refetched or components remounted. The lockfile also reflects updated transitive deps on @metamask/base-data-service (^0.1.3) and @metamask/utils (^11.11.0), plus optional peerDependenciesMeta for react-dom and react-native on the package.

Reviewed by Cursor Bugbot for commit 3b3c9dc. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci metamask-ci Bot added the team-core-platform Core Platform team label Jul 16, 2026
@metamask-ci

metamask-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@socket-security

socket-security Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​react-data-query@​0.2.0 ⏵ 0.2.2721007292 +4100

View full report

@codecov-commenter

codecov-commenter commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.41%. Comparing base (ca991e6) to head (3b3c9dc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33402   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files        6135     6135           
  Lines      163827   163826    -1     
  Branches    39994    39996    +2     
=======================================
+ Hits       138287   138290    +3     
+ Misses      16051    16049    -2     
+ Partials     9489     9487    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding marked this pull request as ready for review July 16, 2026 09:55
@metamask-ci metamask-ci Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 16, 2026
@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jul 16, 2026
@FrederikBolding FrederikBolding added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jul 16, 2026
@FrederikBolding FrederikBolding force-pushed the fb/react-data-query-bug-fix branch from ba6bab0 to 3b3c9dc Compare July 16, 2026 12:20
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeMoney, SmokeSwap, SmokeConfirmations, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 78%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR bumps @metamask/react-data-query from ^0.2.0 to ^0.2.2 (minor version bump). This package provides the useQuery hook used across several key areas:

  1. Card/Money features (useAssetBalances.tsx, useMoneyAccountBalance.ts): These hooks are central to the MetaMask Card and Money (fiat) flows — balance fetching, exchange rate queries, vault APY queries. Any behavioral change in useQuery could affect balance display and Card Add Funds flows → SmokeMoney selected.

  2. Social Leaderboard / Homepage (trader profiles, positions, top traders hooks): These use useQuery for data fetching in the Trending/Homepage sections → SmokeWalletPlatform selected.

  3. ReactQueryService (core infrastructure): Uses createUIQueryClient from this package to set up the global query client. A version change here could affect all query-based data fetching across the app.

Per tag dependency rules:

  • SmokeMoney → also select SmokeSwap and SmokeConfirmations (Card Add Funds flows involve swaps and on-chain transactions)

The minor version bump (0.2.0 → 0.2.2) is likely a bug fix release with low risk of breaking changes, but since it affects core data-fetching infrastructure used in Money/Card and Wallet Platform features, targeted testing of those areas is warranted.

Performance Test Selection:
The change is a minor version bump of @metamask/react-data-query (0.2.0 → 0.2.2). While this package is used in data-fetching hooks, there are no performance spec files changed and no direct evidence that this version bump would measurably impact app launch, login, onboarding, asset loading, or swap performance in ways that would be captured by the available performance test tags. The change is a dependency update, not a modification to performance-sensitive rendering paths.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@FrederikBolding FrederikBolding added this pull request to the merge queue Jul 16, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 16, 2026
@FrederikBolding FrederikBolding added this pull request to the merge queue Jul 16, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 16, 2026
@FrederikBolding FrederikBolding added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit 2cb9a53 Jul 16, 2026
176 of 179 checks passed
@FrederikBolding FrederikBolding deleted the fb/react-data-query-bug-fix branch July 16, 2026 14:14
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
@metamask-ci metamask-ci Bot added the release-8.4.0 Issue or pull request that will be included in release 8.4.0 label Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-8.4.0 Issue or pull request that will be included in release 8.4.0 risk:low AI analysis: low risk size-XS skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants