Skip to content

feat: add support for batch sell on swaps reconciler#33400

Merged
GeorgeGkas merged 2 commits into
mainfrom
swaps-4742
Jul 16, 2026
Merged

feat: add support for batch sell on swaps reconciler#33400
GeorgeGkas merged 2 commits into
mainfrom
swaps-4742

Conversation

@GeorgeGkas

@GeorgeGkas GeorgeGkas commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Updates bridge status controller to latest release that includes support for batch sell in the reconciler.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4742

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches bridge/swaps reconciliation for batch sell; dependency-only but affects how multi-sell transactions are tracked and reconciled at runtime.

Overview
Bumps @metamask/bridge-status-controller from 74.2.0 to 74.3.0 in package.json and yarn.lock only—no mobile app source changes.

The new release is pulled in so the swaps reconciler can handle batch sell flows; behavior lives in the controller package, while the app continues to use BridgeStatusController as before (bridge history, submit, activity rows, post-trade status).

Reviewed by Cursor Bugbot for commit 146a4d8. Bugbot is set up for automated code reviews on this repo. Configure here.

@GeorgeGkas GeorgeGkas added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jul 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-swaps-and-bridge Swaps and Bridge team label Jul 16, 2026
@metamask-ci

metamask-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Manual testing steps still contain template content (the Gherkin example title or a [...] placeholder). Replace with real steps, or write N/A — <reason>.
  • Screenshots/Recordings section is empty. Add an image/video for user-facing changes, logs/console output for non-user-facing changes, or write N/A if no evidence is applicable.
  • Pre-merge author checklist has unchecked items (e.g. "I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions github-actions Bot added size-XS risk:high AI analysis: high risk labels Jul 16, 2026
@GeorgeGkas GeorgeGkas added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jul 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: @PerformanceSwaps
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/bridge-status-controller. Running all tests.

Performance Test Selection:
The @metamask/bridge-status-controller minor version bump could affect swap/bridge transaction performance, particularly quote fetching, bridge status polling, and transaction completion times. The @PerformanceSwaps tag covers swap flow performance including quote fetching, token selection, swap execution, and transaction completion times, which are all potentially impacted by changes in the bridge-status-controller package.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

2 tests failed · 2 tests · 1 device

📱 Devices tested (1)

Android: Google Pixel 8 Pro (v14.0)

❌ Failed Tests (2)

@swap-bridge-dev-team

Test Platform Device Reason Recording
Cross-chain swap flow - ETH to SOL - 50+ accounts, SRP 1 + SRP 2 + SRP 3 Android Google Pixel 8 Pro (v14.0) Test error
Swap flow - ETH to LINK, SRP 1 + SRP 2 + SRP 3 Android Google Pixel 8 Pro (v14.0) Test error

Branch: swaps-4742 · Build: Normal · Commit: 6714d16 · View full run

@GeorgeGkas GeorgeGkas added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit fef858c Jul 16, 2026
223 checks passed
@GeorgeGkas GeorgeGkas deleted the swaps-4742 branch July 16, 2026 14:34
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed risk:high AI analysis: high risk size-XS skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants