test: migrate MMConnect multichain e2e from performance BrowserStack to Appium smoke CI

[chrisleewilcox]

Description

Add a thin-slice Appium smoke path for the active MMConnect multichain browser test, using the standard e2e CI wallet (fixtures) instead of the BrowserStack baked-SRP performance path.

This is a reset of the earlier approach (#31937, closed). Per team guidance: fixtures + scenarioType: 'e2e', CI mocking via withFixtures/DEFAULT_MOCKS, and Chrome on CI via google_apis.

• Add SmokeMMConnect tag and yarn appium-smoke:mmconnect:android
• Add tests/smoke-appium/mm-connect/connection-multichain.spec.ts with withFixtures, Solana permission fixture, e2e login, and safelyOnboardChrome: true
• Wire appium-mmconnect-android-smoke (1 shard, 35 min) with android-tag: google_apis

Not in this PR: removing MMConnect from the performance workflow, migrating the other 11 skipped specs (WAPI-1511).

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1982

Manual testing steps

Feature: SmokeMMConnect thin slice discovery and local run

  Scenario: suite is discoverable under SmokeMMConnect tag
    Given the branch is checked out locally

    When I run `yarn playwright test --config tests/playwright.smoke-appium.config.ts --project android-smoke --grep SmokeMMConnect --list`
    Then 1 test is listed: connection-multichain under SmokeMMConnect

  Scenario: active MMConnect test runs on local Android emulator
    Given a main-e2e release APK is available and a google_apis Android emulator is running

    When I run `yarn appium-smoke:mmconnect:android` with ANDROID_APK_PATH set to the main-e2e APK
    Then connection-multichain.spec.ts passes

Screenshots/Recordings

No app UI changes — CI/test infrastructure thin slice. Evidence is the before/after migration below.

Before

Active MMConnect multichain test lived only in the performance BrowserStack pipeline:

Area	Before
Suite path	tests/performance/mm-connect/connection-multichain.spec.ts
Tag	Performance
Wallet	Baked SRP / loginToAppPlaywright() → E2E_PASSWORD
Mocks	Live/network (no withFixtures)
CI	Performance BrowserStack workflow
Chrome	BrowserStack device Chrome + optional BS Local

After

Thin slice on Appium smoke CI with the standard e2e wallet:

Area	After
Suite path	tests/smoke-appium/mm-connect/connection-multichain.spec.ts
Tag	SmokeMMConnect
Wallet	withFixtures + FixtureBuilder().withSolanaAccountPermission() + scenarioType: 'e2e'
Mocks	DEFAULT_MOCKS via withFixtures
CI	appium-mmconnect-android-smoke (google_apis for Chrome)
Chrome	Emulator Chrome + safelyOnboardChrome: true
Performance suite	Still present on main (removal is follow-up after this job is green)

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Pre-merge author checklist has unchecked items (e.g. "I've documented my code using JSDoc format if applicable"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.40%. Comparing base (96abde9) to head (db35b77).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #33380    +/-   ##
========================================
  Coverage   84.40%   84.40%            
========================================
  Files        6133     6134     +1     
  Lines      163917   163804   -113     
  Branches    40007    39988    -19     
========================================
- Hits       138354   138265    -89     
+ Misses      16054    16050     -4     
+ Partials     9509     9489    -20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🧪 Flaky unit test detection

✅ All previously detected unit test flakiness issues in this PR have been fixed.

View recent run history

This check is informational only and does not block merging.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps, SmokeMMConnect
• Selected Performance tags: None (no tests recommended)
• Risk Level: high
• AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (test-framework-infra-change): Test framework infrastructure changed: tests/framework/fixtures/FixtureBuilder.ts. Running all tests.

Performance Test Selection:
No app code changes in this PR — all changes are test infrastructure, CI workflows, and test utilities. The tests/performance/mm-connect/utils.ts change is a cosmetic refactor (moving unlockIfLockScreenVisible to a shared location, removing the old inline implementation). No performance spec files were added or modified with new performance tags. The PlaywrightContextHelpers.ts, PlaywrightUtilities.ts, and native-browser.flow.ts changes are test-side helpers for Chrome navigation on google_apis emulators, not app code that would affect measured performance metrics. No performance tags should run.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud