chore: relax RelatedAsset validation and filter invalid assets#8920
Open
zone-live wants to merge 4 commits into
Open
chore: relax RelatedAsset validation and filter invalid assets#8920zone-live wants to merge 4 commits into
zone-live wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes a production bug where one relatedAsset missing
sourceAssetIdcaused the entire What's Happening section to show an error state.nameandsourceAssetIdoptional inRelatedAssetStructand
RelatedAssettype (symbolis now the only required field)normalizeRelatedAssetswithfilterAndNormalizeRelatedAssetswhich strips assets with empty
symboland drops trends with zerovalid assets after filtering
References
Checklist
Note
Medium Risk
Changes public RelatedAsset typing and silently drops trends/assets; consumers must handle optional name/sourceAssetId and possibly fewer trends than the raw API sent.
Overview
Fixes a production failure where
fetchMarketOverviewrejected the whole market-overview payload when anyrelatedAssetlackednameorsourceAssetId, breaking the What's Happening UI.RelatedAssetvalidation and types now treatnameandsourceAssetIdas optional;symbolis the only required field. Post-validation normalization was renamed tofilterAndNormalizeRelatedAssets: it still fills missingcaip19with[], removes assets with emptysymbol, and drops trends that end up with no valid related assets (overview can returntrends: []instead of throwing). Changelog and service tests cover the new behavior.Reviewed by Cursor Bugbot for commit 856ef80. Bugbot is set up for automated code reviews on this repo. Configure here.