fix: remove fully-shadowed dead StorageMixin in memory/storage.py

[praisonai-triage-agent]

Fixes #2138

Summary

Remove StorageMixin from praisonaiagents/memory/storage.py, a base class of Memory where all 10 methods are completely overridden and never reached - the entire mixin is unreachable dead code.

Changes

• Removed StorageMixin from the Memory base class list
• Removed the import of StorageMixin
• Deleted the memory/storage.py file (~233 lines of dead code)

Impact

• No behavior change - The live methods in the Memory class body remain unchanged and continue to execute
• Removes maintenance risk - Eliminates stale code that had already diverged from live implementation
• Cleaner codebase - 233 lines of unreachable code removed

Verification

All 10 StorageMixin methods were verified to be redefined in Memory class:

• _get_stm_conn (line 317)
• _get_ltm_conn (line 339)
• _init_stm (line 389)
• _init_ltm (line 404)
• _init_chroma (line 464)
• _init_mongodb (line 499)
• _create_mongodb_indexes (line 540)
• _create_vector_search_indexes (line 564)
• reset_short_term (line 866)
• reset_long_term (line 1176)

The mixin versions were unreachable by Python's MRO since Memory is the most-derived class.

Note

SearchMixin and MemoryCoreMixin remain untouched as they are only partially overridden and contain live methods.

Summary by CodeRabbit

Release Notes

• Refactor
  • Removed memory persistence and storage features. The system no longer supports maintaining data across multiple storage backends or provides memory reset functionality.

[MervinPraison]

@coderabbitai review

[MervinPraison]

/review

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d47ffc80-cacf-417c-b47c-ada948f74949

📥 Commits

Reviewing files that changed from the base of the PR and between 5f39d66 and 0fa4d88.

📒 Files selected for processing (2)

• src/praisonai-agents/praisonaiagents/memory/memory.py
• src/praisonai-agents/praisonaiagents/memory/storage.py

💤 Files with no reviewable changes (1)

• src/praisonai-agents/praisonaiagents/memory/storage.py

---

📝 Walkthrough

Walkthrough

Removes the fully-shadowed StorageMixin from the Memory class by deleting its import in memory.py and dropping it from the inheritance list. The storage.py file containing StorageMixin and its 233 lines of dead storage logic is deleted entirely.

Changes

StorageMixin Dead Code Removal

Layer / File(s)

Summary

Drop StorageMixin import and inheritance src/praisonai-agents/praisonaiagents/memory/memory.py, src/praisonai-agents/praisonaiagents/memory/storage.py

Removes from .storage import StorageMixin import and updates Memory class signature from Memory(StorageMixin, SearchMixin, MemoryCoreMixin) to Memory(SearchMixin, MemoryCoreMixin). Deletes storage.py in full, removing the StorageMixin class and all 10 of its methods (_get_stm_conn, _get_ltm_conn, _init_stm, _init_ltm, _init_chroma, _init_mongodb, _create_mongodb_indexes, _create_vector_search_indexes, reset_short_term, reset_long_term).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• MervinPraison

Poem

🐇 A mixin once hid in the code's dusty lair,
Its methods all shadowed — not one got called there!
With a snip and a hop, the dead code is gone,
The Memory class hops lightly on.
Less is more, says the rabbit — now carry on! 🌿

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: removing the fully-shadowed, unreachable StorageMixin from the Memory class inheritance.
Linked Issues check	✅ Passed	All code-related objectives from issue #2138 are met: StorageMixin is removed from Memory's base class, the import is removed, and the 233-line storage.py file is deleted, eliminating all 10 shadowed methods.
Out of Scope Changes check	✅ Passed	All changes are within scope of issue #2138. The removal of StorageMixin, its import, and the storage.py file directly address the dead code elimination objective with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/issue-2138-20260621-1711

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[MervinPraison]

@copilot Do a thorough review of this PR. Read ALL existing reviewer comments above from Qodo, Coderabbit, and Gemini first — incorporate their findings.

Review areas:

1. Bloat check: Are changes minimal and focused? Any unnecessary code or scope creep?
2. Security: Any hardcoded secrets, unsafe eval/exec, missing input validation?
3. Performance: Any module-level heavy imports? Hot-path regressions?
4. Tests: Are tests included? Do they cover the changes adequately?
5. Backward compat: Any public API changes without deprecation?
6. Code quality: DRY violations, naming conventions, error handling?
7. Address reviewer feedback: If Qodo, Coderabbit, or Gemini flagged valid issues, include them in your review
8. Suggest specific improvements with code examples where possible

[greptile-apps]

Greptile Summary

This PR removes StorageMixin from praisonaiagents/memory/memory.py and deletes the memory/storage.py file (~233 lines). The mixin was a dead base class — Python's MRO guarantees that all methods defined directly on Memory take precedence, and all 10 StorageMixin methods are confirmed to be overridden in Memory's own body.

• The import of StorageMixin and its presence in the class bases list are removed from memory.py, with Memory now inheriting only from SearchMixin and MemoryCoreMixin.
• storage.py is deleted entirely; a codebase-wide grep finds zero remaining references to StorageMixin, and __init__.py never exported it, so the public API is unchanged.

Confidence Score: 5/5

Safe to merge — the deletion removes exclusively unreachable code with no effect on runtime behavior.

All 10 StorageMixin methods are confirmed to be overridden directly in Memory's class body, making the mixin unreachable via Python MRO. No other file in the repository imports or references StorageMixin, and it was never part of the public API (init.py does not export it). The live Memory implementations are more capable than the mixin versions they shadow (e.g., WAL mode, busy timeout). This is a clean dead-code removal with zero risk of regression.

No files require special attention.

Important Files Changed

Filename	Overview
src/praisonai-agents/praisonaiagents/memory/memory.py	Removes StorageMixin from the class base list and its import; all 10 mixin methods are confirmed present and more feature-rich in Memory's own body — no behavior change.
src/praisonai-agents/praisonaiagents/memory/storage.py	Deleted entirely — all 10 methods it contained were fully shadowed by Memory's own definitions and were unreachable by MRO; no external code imported this file.

Class Diagram

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class SearchMixin {
        +_safe_mem0_search()
        +search_short_term()
        +search_long_term()
    }
    class MemoryCoreMixin {
        +build_context_for_task()
        +finalize_task_output()
        +store_entity()
        +search_entity()
    }
    class Memory {
        +_get_stm_conn()
        +_get_ltm_conn()
        +_init_stm()
        +_init_ltm()
        +_init_chroma()
        +_init_mongodb()
        +_create_mongodb_indexes()
        +_create_vector_search_indexes()
        +reset_short_term()
        +reset_long_term()
        +store_short_term()
        +store_long_term()
        +close_connections()
    }
    class StorageMixin {
        <<deleted>>
        +_get_stm_conn()
        +_get_ltm_conn()
        +_init_stm()
        +_init_ltm()
        +_init_chroma()
        +_init_mongodb()
        +_create_mongodb_indexes()
        +_create_vector_search_indexes()
        +reset_short_term()
        +reset_long_term()
    }
    Memory --|> SearchMixin
    Memory --|> MemoryCoreMixin
    StorageMixin ..|> Memory : all 10 methods fully shadowed by Memory body (removed by this PR)

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
classDiagram
    class SearchMixin {
        +_safe_mem0_search()
        +search_short_term()
        +search_long_term()
    }
    class MemoryCoreMixin {
        +build_context_for_task()
        +finalize_task_output()
        +store_entity()
        +search_entity()
    }
    class Memory {
        +_get_stm_conn()
        +_get_ltm_conn()
        +_init_stm()
        +_init_ltm()
        +_init_chroma()
        +_init_mongodb()
        +_create_mongodb_indexes()
        +_create_vector_search_indexes()
        +reset_short_term()
        +reset_long_term()
        +store_short_term()
        +store_long_term()
        +close_connections()
    }
    class StorageMixin {
        <<deleted>>
        +_get_stm_conn()
        +_get_ltm_conn()
        +_init_stm()
        +_init_ltm()
        +_init_chroma()
        +_init_mongodb()
        +_create_mongodb_indexes()
        +_create_vector_search_indexes()
        +reset_short_term()
        +reset_long_term()
    }
    Memory --|> SearchMixin
    Memory --|> MemoryCoreMixin
    StorageMixin ..|> Memory : all 10 methods fully shadowed by Memory body (removed by this PR)

Loading

_{Reviews (1): Last reviewed commit: "fix: remove unreferenced dead code in co..." | Re-trigger Greptile}

[MervinPraison]

@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on Python packages (praisonaiagents, praisonai). Do NOT modify praisonai-rust or praisonai-ts. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding.

Phase 1: Review per AGENTS.md

1. Protocol-driven: check heavy implementations vs core SDK
2. Backward compatible: ensure zero feature regressions
3. Performance: no hot-path regressions

Phase 2: FIX Valid Issues
4. For any VALID bugs or architectural flaws found by Gemini, CodeRabbit, Qodo, Copilot, or any other reviewer: implement the fix
5. Push all code fixes directly to THIS branch (do NOT create a new PR)
6. Comment a summary of exact files modified and what you skipped

Phase 3: Final Verdict
7. If all issues are resolved, approve the PR / close the Issue
8. If blocking issues remain, request changes / leave clear action items

[praisonai-triage-agent]

Claude finished @MervinPraison's task —— View job

---

Final Architecture Review Complete ✅

Todo List

• Set up git identity and auth
• Read AGENTS.md architecture guidelines
• Review code changes in detail
• Analyze feedback from Qodo, CodeRabbit, Copilot, and Greptile
• Check protocol-driven design compliance
• Verify backward compatibility
• Check for performance regressions
• Implement any valid fixes found (none found - all reviewers agree it's safe)
• Run tests if possible (import test passed)
• Provide final verdict

Phase 1: Architecture Review per AGENTS.md

✅ Protocol-driven: Removing 233 lines of dead code aligns with keeping core SDK lean
✅ Backward compatible: No public API changes - StorageMixin was never exported via __init__.py
✅ Performance: Marginally improves import time by eliminating unused code

Phase 2: Reviewer Analysis

All reviewers confirmed this is safe dead code removal:

• CodeRabbit: No actionable issues, pre-merge checks all passed
• Greptile: Confidence 5/5, exclusively unreachable code with zero runtime impact
• Qodo: No review (paused), no issues raised

No valid bugs or architectural flaws found - all 10 StorageMixin methods are completely overridden in Memory class body with more capable implementations (WAL mode, busy timeout, etc.)

Phase 3: Final Verdict

APPROVED ✅ - This PR safely removes 233 lines of fully-shadowed, unreachable dead code without any behavior changes or API impact. The Memory class continues to function identically using its own method implementations.

Summary

• Files Modified: None (no fixes needed)
• What was skipped: No issues to fix - all reviewers confirmed safe removal
• Testing: Memory class imports successfully post-removal

---