ci: authenticate private screenpipe-fork git dep in the Rust job#331
Merged
Conversation
The CI Rust job (fmt/clippy/test) resolves the whole workspace, including
the tray's optional capture deps (screenpipe-screen/-a11y) which are a git
dependency on the PRIVATE Meridiona/screenpipe-fork. With only the repo-scoped
GITHUB_TOKEN, cargo's `git fetch` of the fork fails ("could not read Username
for github.com"), so clippy/test never start.
Port the exact mechanism release.yml / release-staging.yml already use:
- CARGO_NET_GIT_FETCH_WITH_CLI=true so cargo honors url.insteadOf (libgit2 won't)
- a git config step rewriting the fork URL to embed secrets.GH_TOKEN
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SKdh3tKWLZhtQ9FCfA5RYH
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on #330 (
pre-main→main) fails at the Rust job:ci.yml'srustjob runscargo fmt/clippy/testover the whole workspace. That resolves the tray'sscreenpipe-screen/screenpipe-a11ydeps — a git dependency on the privateMeridiona/screenpipe-fork— even though they'reoptional/capture-gated and never compiled here. With only the repo-scopedGITHUB_TOKEN, cargo'sgit fetchof the fork can't authenticate, so the job dies before clippy even runs.Fix
Port the exact mechanism
release.ymlandrelease-staging.ymlalready use (those jobs build the tray against the fork and pass):CARGO_NET_GIT_FETCH_WITH_CLI: "true"on therustjob — cargo's libgit2 ignoresurl.insteadOf; the git CLI honors it.git config --global url."https://x-access-token:${GH_TOKEN}@…".insteadOf …step usingsecrets.GH_TOKEN(already proven to read the fork — thereleasecheck is green on release: fold dashboard into Tauri + self-contained DMG + in-process capture (pre-main → main) #330).No source/build changes; CI-only. Merging this into
pre-mainre-triggers #330's CI, which should then go green.🤖 Generated with Claude Code