Skip to content

Fix missing highlight for Qt 6.10#4511

Open
Withalion wants to merge 8 commits into
dev/qt-6.10.2from
fix/highlight-6.10
Open

Fix missing highlight for Qt 6.10#4511
Withalion wants to merge 8 commits into
dev/qt-6.10.2from
fix/highlight-6.10

Conversation

@Withalion
Copy link
Copy Markdown
Contributor

@Withalion Withalion commented May 22, 2026

Alternative approach to #4506

In Qt 6.9+ instead of triggering onPropertyChanged signal first the value checks for equality. QgsGeometry doesn't have equality operator, but has equals() method instead. We wrap QgsGeometry in MMGeometry class which adds equality operator (this just calls equals()). All QgsGeometry values should be exposed to QML through MMGeometry for bindings to work properly.

Just a thought: should we prohibit the usage of QgsGeometry in the app?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Coverage Report for CI Build 26304692655

Coverage increased (+0.06%) to 57.838%

Details

  • Coverage increased (+0.06%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 6 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

6 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
mm/app/position/tracking/positiontrackinghighlight.cpp 4 84.21%
mm/app/multieditmanager.h 2 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 15234
Covered Lines: 8811
Line Coverage: 57.84%
Coverage Strength: 99.19 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68681 dmg Expires: 20/08/2026 #6868
linux Build Build failed or not found. #6888
win64 Build Build failed or not found. #6062
Android Build 📬 Mergin Maps 817811 APK [armeabi-v7a] Expires: 20/08/2026 #8178
📬 Mergin Maps 817811 APK [armeabi-v7a] Google Play Store #8178
Android Build 📬 Mergin Maps 817851 APK [arm64-v8a] Expires: 20/08/2026 #8178
📬 Mergin Maps 817851 APK [arm64-v8a] Google Play Store #8178
iOS Build 📬 Build number: 26.05.912011 #9120

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68681 dmg Expires: 20/08/2026 #6868
linux Build Build failed or not found. #6888
win64 Build 📬 Mergin Maps 60622 win64 Expires: 20/08/2026 #6062
Android Build 📬 Mergin Maps 817811 APK [armeabi-v7a] Expires: 20/08/2026 #8178
📬 Mergin Maps 817811 APK [armeabi-v7a] Google Play Store #8178
Android Build 📬 Mergin Maps 817851 APK [arm64-v8a] Expires: 20/08/2026 #8178
📬 Mergin Maps 817851 APK [arm64-v8a] Google Play Store #8178
iOS Build 📬 Build number: 26.05.912011 #9120

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68681 dmg Expires: 20/08/2026 #6868
linux Build 📬 Mergin Maps 68882 x86_64 Expires: 24/08/2026 #6888
win64 Build 📬 Mergin Maps 60622 win64 Expires: 20/08/2026 #6062
Android Build 📬 Mergin Maps 817811 APK [armeabi-v7a] Expires: 20/08/2026 #8178
📬 Mergin Maps 817811 APK [armeabi-v7a] Google Play Store #8178
Android Build 📬 Mergin Maps 817851 APK [arm64-v8a] Expires: 20/08/2026 #8178
📬 Mergin Maps 817851 APK [arm64-v8a] Google Play Store #8178
iOS Build 📬 Build number: 26.05.912011 #9120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant