Skip to content

DUX-5510 re_grpc: zstd-compress large BatchUpdateBlobs blobs#26

Merged
9999years merged 1 commit into
mercury-headfrom
wiggles/dux-5510/nuwy
Jul 9, 2026
Merged

DUX-5510 re_grpc: zstd-compress large BatchUpdateBlobs blobs#26
9999years merged 1 commit into
mercury-headfrom
wiggles/dux-5510/nuwy

Conversation

@9999years

@9999years 9999years commented Jul 9, 2026

Copy link
Copy Markdown
Member

Compress batched blob uploads whose data exceeds a configurable threshold (default 100 bytes) with zstd, when the server advertises zstd in its supported_batch_update_compressors capability.

It's hard to quantify the benefits of this without getting a packet capture from a CI build, so I'm not going to do that. But given the benefits we saw in #22, it should be a nice bonus.

@linear-code

linear-code Bot commented Jul 9, 2026

Copy link
Copy Markdown

DUX-5510

@9999years
9999years requested review from csamak and lf- July 9, 2026 17:09
@9999years
9999years force-pushed the wiggles/dux-5510/nuwy branch from 441a709 to 0ede09c Compare July 9, 2026 17:11

@lf- lf- left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add more to the commit message related to the expected uplift from this.

Comment thread remote_execution/oss/re_grpc/src/client.rs Outdated
Compress batched blob uploads whose `data` exceeds a configurable
threshold (default 100 bytes) with zstd, when the server advertises zstd
in its `supported_batch_update_compressors` capability.
@9999years
9999years force-pushed the wiggles/dux-5510/nuwy branch from 0ede09c to 0370e84 Compare July 9, 2026 18:50
@9999years
9999years marked this pull request as ready for review July 9, 2026 18:53
@9999years
9999years requested review from a team and dtpowl July 9, 2026 18:53
@9999years
9999years enabled auto-merge (squash) July 9, 2026 18:53
@9999years
9999years requested a review from lf- July 9, 2026 18:54
@9999years
9999years merged commit 85f9496 into mercury-head Jul 9, 2026
3 checks passed
@9999years
9999years deleted the wiggles/dux-5510/nuwy branch July 9, 2026 19:43
hdgarrood pushed a commit that referenced this pull request Jul 10, 2026
Compress batched blob uploads whose `data` exceeds a configurable
threshold (default 100 bytes) with zstd, when the server advertises zstd
in its `supported_batch_update_compressors` capability.
hdgarrood pushed a commit that referenced this pull request Jul 11, 2026
Compress batched blob uploads whose `data` exceeds a configurable
threshold (default 100 bytes) with zstd, when the server advertises zstd
in its `supported_batch_update_compressors` capability.
hdgarrood pushed a commit that referenced this pull request Jul 11, 2026
Compress batched blob uploads whose `data` exceeds a configurable
threshold (default 100 bytes) with zstd, when the server advertises zstd
in its `supported_batch_update_compressors` capability.
hdgarrood pushed a commit that referenced this pull request Jul 15, 2026
Compress batched blob uploads whose `data` exceeds a configurable
threshold (default 100 bytes) with zstd, when the server advertises zstd
in its `supported_batch_update_compressors` capability.
hdgarrood pushed a commit that referenced this pull request Jul 15, 2026
Compress batched blob uploads whose `data` exceeds a configurable
threshold (default 100 bytes) with zstd, when the server advertises zstd
in its `supported_batch_update_compressors` capability.
hdgarrood pushed a commit that referenced this pull request Jul 15, 2026
Compress batched blob uploads whose `data` exceeds a configurable
threshold (default 100 bytes) with zstd, when the server advertises zstd
in its `supported_batch_update_compressors` capability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants