Skip to content

fix(memos-local-plugin): harden Hermes install and startup recovery#1745

Open
yyswhsccc wants to merge 1 commit into
MemTensor:mainfrom
yyswhsccc:bounty-radar/issue-1744-hermes-health-install
Open

fix(memos-local-plugin): harden Hermes install and startup recovery#1745
yyswhsccc wants to merge 1 commit into
MemTensor:mainfrom
yyswhsccc:bounty-radar/issue-1744-hermes-health-install

Conversation

@yyswhsccc
Copy link
Copy Markdown

Summary

Fixes #1744.

  • install the Hermes provider into the durable user-plugin path ~/.hermes/plugins/memtensor, while still writing the legacy ~/.hermes/hermes-agent/plugins/memory/memtensor compatibility link when that source-tree path exists
  • mirror the durable provider link in the Windows installer and adapter installer helper
  • defer dirty closed episode reward rescore out of startup init() so the bridge can become responsive while recovery continues in the background
  • add focused tests for the durable install contract and async dirty-rescore behavior

Validation

  • bash -n install.sh adapters/hermes/install.hermes.sh
  • npx vitest run tests/unit/install/install-sh.test.ts -t "durable user-plugin"
  • npx vitest run tests/unit/pipeline/memory-core.test.ts -t "rescoring"
  • npm run lint
  • python -m pytest apps/memos-local-plugin/tests/python -q (33 passed after installing PyYAML in the isolated local test venv)

Note: npx vitest run tests/unit/install/install-sh.test.ts tests/unit/pipeline/memory-core.test.ts also passed the install test file, but the broader memory-core.test.ts run still reports three unrelated existing namespace/topic behavior failures outside this patch scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Hermes provider symlink breaks after upgrade and bridge health can timeout during startup recovery

1 participant