Skip to content

issue: 1117626 Move epoll poll_os logic to the internal thread#460

Closed
liranoz12 wants to merge 4 commits into
Mellanox:masterfrom
liranoz12:move_poll_os_epoll
Closed

issue: 1117626 Move epoll poll_os logic to the internal thread#460
liranoz12 wants to merge 4 commits into
Mellanox:masterfrom
liranoz12:move_poll_os_epoll

Conversation

@liranoz12

@liranoz12 liranoz12 commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@liranoz12 liranoz12 changed the title Move poll os epoll issue: 1117626 Move epoll poll_os logic to the internal thread Aug 31, 2017
@liranoz12

liranoz12 commented Aug 31, 2017

Copy link
Copy Markdown
Contributor Author

The commit is based on #445

@mellanox-github

mellanox-github commented Aug 31, 2017

Copy link
Copy Markdown

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1634/ for details (Mellanox internal link).

@liranoz12 liranoz12 removed the vNext label Sep 4, 2017
issue: 1117626 Move epoll poll_os logic to the internal thread
f0adf45 
This commit is not based on udp poll os commit (pr Mellanox#445).

Signed-off-by: Liran Oz <lirano@mellanox.com>
@mellanox-github

mellanox-github commented Sep 4, 2017

Copy link
Copy Markdown

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1642/ for details (Mellanox internal link).

@DanielLibenson

DanielLibenson commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

bot:reset

@liranoz12

liranoz12 commented Sep 5, 2017

Copy link
Copy Markdown
Contributor Author

bot:retest

@mellanox-github

mellanox-github commented Sep 5, 2017

Copy link
Copy Markdown

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1643/ for details (Mellanox internal link).

@liranoz12 liranoz12 removed the vNext label Sep 11, 2017
issue: 1117626 Move epoll poll_os logic to the internal thread
b1de6f5 
Fix review comments

Signed-off-by: Liran Oz <lirano@mellanox.com>
@swx-jenkins3

swx-jenkins3 commented Sep 13, 2017

Copy link
Copy Markdown

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1661/ for details (Mellanox internal link).

DanielLibenson
DanielLibenson approved these changes Sep 13, 2017
View reviewed changes
Comment thread src/vma/iomux/io_mux_call.cpp Outdated
*/
if (poll_os_countdown-- == 0 && m_n_sysvar_select_poll_os_ratio > 0) {
bool cq_ready = wait_os(true);
if (cq_ready) {

@DanielLibenson DanielLibenson Sep 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to move wait_os() inside if statement.

@liranoz12 liranoz12 Sep 13, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanielLibenson

DanielLibenson commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

👍

issue: 1117626 Move epoll poll_os logic to the internal thread
6a0b53a 
Remove boolean var from io_mux_call::handle_os_countdown()

Signed-off-by: Liran Oz <lirano@mellanox.com>
@liranoz12 liranoz12 added vNext and removed In Review labels Sep 13, 2017
@swx-jenkins3

swx-jenkins3 commented Sep 13, 2017

Copy link
Copy Markdown

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1664/ for details (Mellanox internal link).

@liranoz12

liranoz12 commented Sep 13, 2017

Copy link
Copy Markdown
Contributor Author

bot:retest

@swx-jenkins3

swx-jenkins3 commented Sep 13, 2017

Copy link
Copy Markdown

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1667/ for details (Mellanox internal link).

@liranoz12 liranoz12 removed the vNext label Sep 14, 2017
issue: 1117626 Move epoll poll_os logic to the internal thread
94f8292 
Add doc

Signed-off-by: Liran Oz <lirano@mellanox.com>
@swx-jenkins3

swx-jenkins3 commented Sep 17, 2017

Copy link
Copy Markdown

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1676/ for details (Mellanox internal link).

@liranoz12

liranoz12 commented Sep 17, 2017

Copy link
Copy Markdown
Contributor Author

Merged #460

@liranoz12 liranoz12 closed this Sep 17, 2017
@liranoz12 liranoz12 deleted the move_poll_os_epoll branch September 17, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@DanielLibenson DanielLibenson DanielLibenson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liranoz12 @mellanox-github @DanielLibenson @swx-jenkins3