Skip to content

Fix/python3.14build #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddimmich wants to merge 2 commits into
base: master
Choose a base branch
from
+31 −113
Open

Fix/python3.14build #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d0049
Bump pyo3 from 0.27.1 to 0.29.0
dependabot[bot] Jun 12, 2026
4821749
ditch 3.13t as its no longer supported by Py03
ddimmich Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 18 additions & 37 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,15 @@ jobs:
id: setup_freethreaded
continue-on-error: true
with:
python-version: |
3.13t
3.14t
python-version: 3.14t
- name: Configure maturin interpreters
shell: bash
run: |
INTERP='3.8 3.9 3.10 3.11 3.12 3.13 3.14'
if [[ '${{ steps.setup_freethreaded.outcome }}' == 'success' ]]; then
INTERP="$INTERP 3.13t 3.14t"
INTERP="$INTERP 3.14t"
else
echo '::warning::Free-threaded Python (3.13t/3.14t) unavailable from setup-python; skipping cp313t/cp314t wheels this run.'
echo '::warning::Free-threaded Python (3.14t) unavailable from setup-python; skipping cp314t wheels this run.'
fi
echo "MATURIN_INTERPRETERS=$INTERP pypy3.11" >> "$GITHUB_ENV"
- name: Build wheels
Expand Down Expand Up @@ -92,17 +90,15 @@ jobs:
id: setup_freethreaded
continue-on-error: true
with:
python-version: |
3.13t
3.14t
python-version: 3.14t
- name: Configure maturin interpreters
shell: bash
run: |
INTERP='3.8 3.9 3.10 3.11 3.12 3.13 3.14'
if [[ '${{ steps.setup_freethreaded.outcome }}' == 'success' ]]; then
INTERP="$INTERP 3.13t 3.14t"
INTERP="$INTERP 3.14t"
else
echo '::warning::Free-threaded Python (3.13t/3.14t) unavailable from setup-python; skipping cp313t/cp314t wheels this run.'
echo '::warning::Free-threaded Python (3.14t) unavailable from setup-python; skipping cp314t wheels this run.'
fi
echo "MATURIN_INTERPRETERS=$INTERP pypy3.11" >> "$GITHUB_ENV"
- name: Build wheels
Expand All @@ -129,9 +125,8 @@ jobs:
target: x86
steps:
- uses: actions/checkout@v4
# Windows: install standard CPython only first, run maturin, then add 3.13t/3.14t and maturin again.
# If both GIL and free-threaded are on PATH before a single maturin run, detection picks 3.13t for 3.13
# and cp313/cp314 wheels are missing on win_amd64 (see https://github.com/PyO3/maturin-action/issues/313).
# Windows: install standard CPython only first, run maturin, then add 3.14t and maturin again.
# 3.13t is not supported by recent PyO3
- uses: actions/setup-python@v5
with:
python-version: |
Expand All @@ -156,20 +151,18 @@ jobs:
id: setup_freethreaded
continue-on-error: true
with:
python-version: |
3.13t
3.14t
python-version: 3.14t
architecture: ${{ matrix.platform.target }}
- name: Warn if free-threaded Python unavailable
if: steps.setup_freethreaded.outcome != 'success'
run: |
echo '::warning::Free-threaded Python (3.13t/3.14t) unavailable from setup-python; skipping cp313t/cp314t wheels this run.'
echo '::warning::Free-threaded Python (3.14t) unavailable from setup-python; skipping cp314t wheels this run.'
- name: Build wheels (free-threaded)
if: steps.setup_freethreaded.outcome == 'success'
uses: PyO3/maturin-action@v1
with:
target: ${{ matrix.platform.target }}
args: --release --out dist -i 3.13t 3.14t
args: --release --out dist -i 3.14t
sccache: 'true'
- name: Upload wheels
uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -201,17 +194,15 @@ jobs:
id: setup_freethreaded
continue-on-error: true
with:
python-version: |
3.13t
3.14t
python-version: 3.14t
- name: Configure maturin interpreters
shell: bash
run: |
INTERP='3.8 3.9 3.10 3.11 3.12 3.13 3.14'
if [[ '${{ steps.setup_freethreaded.outcome }}' == 'success' ]]; then
INTERP="$INTERP 3.13t 3.14t"
INTERP="$INTERP 3.14t"
else
echo '::warning::Free-threaded Python (3.13t/3.14t) unavailable from setup-python; skipping cp313t/cp314t wheels this run.'
echo '::warning::Free-threaded Python (3.14t) unavailable from setup-python; skipping cp314t wheels this run.'
fi
echo "MATURIN_INTERPRETERS=$INTERP pypy3.11" >> "$GITHUB_ENV"
- name: Build wheels
Expand All @@ -230,24 +221,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
# Try 3.14t first, then 3.13t. Use outcome (not conclusion): continue-on-error leaves conclusion "success"
# Try 3.14t first. Use outcome (not conclusion) - 3.13t isn't supported: continue-on-error leaves conclusion "success"
# even when setup fails, but outcome stays "failure" so we can chain fallbacks reliably.
- uses: actions/setup-python@v5
id: py314t
continue-on-error: true
with:
python-version: '3.14t'
- uses: actions/setup-python@v5
id: py313t
if: steps.py314t.outcome != 'success'
continue-on-error: true
with:
python-version: '3.13t'
- name: Resolve free-threaded interpreter
id: ft_py
run: |
ready=false
if [[ '${{ steps.py314t.outcome }}' == 'success' ]] || [[ '${{ steps.py313t.outcome }}' == 'success' ]]; then
if [[ '${{ steps.py314t.outcome }}' == 'success' ]]; then
ready=true
fi
echo "ready=${ready}" >> "$GITHUB_OUTPUT"
Expand All @@ -260,17 +245,13 @@ jobs:
shell: bash
run: |
set -euo pipefail
if [[ '${{ steps.py314t.outcome }}' == 'success' ]]; then
export UV_PYTHON='${{ steps.py314t.outputs.python-path }}'
else
export UV_PYTHON='${{ steps.py313t.outputs.python-path }}'
fi
export UV_PYTHON='${{ steps.py314t.outputs.python-path }}'
uv sync --extra dev --locked
uv run pytest tests/
- name: Free-threaded Python unavailable
if: steps.ft_py.outputs.ready != 'true'
run: |
echo '::notice::No free-threaded Python (3.14t / 3.13t) available from setup-python for this runner; skipping extension tests.'
echo '::notice::No free-threaded Python (3.14t) available from setup-python for this runner; skipping extension tests.'

sdist:
runs-on: ubuntu-latest
Expand Down
87 changes: 12 additions & 75 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ name = "bidi"
crate-type = ["cdylib"]

[dependencies]
pyo3 = { version = "0.27.1", features = [
pyo3 = { version = "0.29.0", features = [
"extension-module",
"generate-import-lib",
] }
Expand Down