feat(ui): make instructor cards fully clickable and add scroll-to-top component#25
Open
nitishchaubeyy wants to merge 2 commits into
Open
feat(ui): make instructor cards fully clickable and add scroll-to-top component#25nitishchaubeyy wants to merge 2 commits into
nitishchaubeyy wants to merge 2 commits into
Conversation
|
@nitishchaubeyy is attempting to deploy a commit to the Mehren's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mehren7
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the
InstructorCardcomponent to make the entire card surface clickable, significantly improving the touch target area for mobile users and the overall navigation UX. Additionally, it resolves a missing module error that was crashing the development server by introducing a clean, theme-alignedScrollToTopcomponent.Related Issue 🔗
Closes #24
Changes Made 🛠️
after:absolute after:inset-0) on the Next.js<Link>component. This expands the clickable area over the entire card without causing invalid HTML nesting (like wrapping<a>tags inside<a>tags).relative z-10to the price badge and specialty tags within the card to ensure they remain cleanly layered and text remains selectable.ScrollToTop.tsxcomponent in thecomponents/directory. It features a minimalist design matching the platform's violet theme and appears smoothly after scrolling 300px.Testing ✅
ScrollToTopbutton appears on scroll and smoothly returns the user to the top of the page.Module not founderrors.