MekHQ #9728 Data - #503
Open
IllianiBird wants to merge 13 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new Special Pilot Abilities (SPAs) to mm-data needed by MekHQ PR #9728’s Chaos Campaign Reputation / personnel reputation work, expanding the default SPA catalog with reputation-, piracy-, and commander-impacting traits.
Changes:
- Added a set of new SPAs affecting Chaos Campaign Reputation calculations (Fame/Connections modifiers; experience/reputation averaging adjustments).
- Added new SPAs affecting piracy-related outcomes (criminal record changes; likelihood of being caught; loot yield).
- Introduced mutual-exclusion (
invalidAbilities) pairings for opposing traits.
Suppressed comments (3)
data/universe/defaultspa.xml:2771
- Grammar: this sentence is missing a verb ("...or reduced effect..."). Consider using "or has reduced effect" for clarity.
Has no effect if Chaos Campaign Reputation is disabled or reduced effect if Campaign Tracked Chaos Reputation is enabled.]]></desc>
data/universe/defaultspa.xml:2843
- Grammar: this sentence is missing a verb ("...or reduced effect..."). Consider using "or has reduced effect" for clarity.
Has no effect if Chaos Campaign Reputation is disabled or reduced effect if Campaign Tracked Chaos Reputation is enabled.]]></desc>
data/universe/defaultspa.xml:2831
- Grammar: this sentence is missing a verb ("...or reduced effect..."). Consider using "or has reduced effect" for clarity.
Has no effect if Chaos Campaign Reputation is disabled or reduced effect if Campaign Tracked Chaos Reputation is enabled.]]></desc>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <displayName>Big Personality</displayName> | ||
| <desc><![CDATA[This character counts twice when determining the force's average Experience and Chaos Campaign Reputation. | ||
|
|
||
| Has no effect if Chaos Campaign Reputation is disabled or reduced effect if Campaign Tracked Chaos Reputation is enabled.]]></desc> |
| <ability> | ||
| <lookupName>leaves_no_trail</lookupName> | ||
| <displayName>Leaves No Trail</displayName> | ||
| <desc><
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by MegaMek/mekhq#9728