Add Mnemosyne architecture design diagrams (S1 and S2)#376
Draft
palashkondekar-meesho wants to merge 2 commits into
Draft
Add Mnemosyne architecture design diagrams (S1 and S2)#376palashkondekar-meesho wants to merge 2 commits into
palashkondekar-meesho wants to merge 2 commits into
Conversation
…orm LLD Excalidraw component diagrams for the two sharding strategies under review: - S1: deployable-per-shard (read-replicas, Envoy intra-shard LB) - S2: scattered regions (TiDB-like, Placement-Driver-managed) https://claude.ai/code/session_01FM9sB54w7ry9GH7iU2qbqv
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
…-tenant, internal scaling) Companion to the Mnemosyne LLD. Shows the onboarding lane (admin -> API -> sizer -> tenant outputs), shared Control Plane + Producer/GCS, and three tenant lanes with per-tenant Client SDK and internal shard deployables (one with a scaled-up replica to illustrate horizontal scaling within a shard). https://claude.ai/code/session_01FM9sB54w7ry9GH7iU2qbqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
This PR adds architectural design diagrams for Mnemosyne, documenting two distinct deployment strategies for the feature store system. These diagrams serve as visual references for understanding the system topology and component interactions.
Describe your changes:
Added two Excalidraw design documents:
mnemosyne-s1-deployable-per-shard.excalidraw: Illustrates the S1 architecture with shard-based deployment strategy
mnemosyne-s2-scattered-regions.excalidraw: Illustrates the S2 architecture with TiDB-like region-based strategy
Both diagrams document the complete data flow from generation through serving, including control plane interactions and client-side logic.
Testing:
N/A - These are design documentation artifacts (Excalidraw JSON files) with no executable code or tests.
Monitoring:
N/A - Design documentation only.
Rollback plan:
N/A - Design documentation only. Can be removed or updated without affecting system operation.
Checklist before requesting a review:
📂 Modules Affected:
docs(Documentation updates)✅ Type of Change:
https://claude.ai/code/session_01FM9sB54w7ry9GH7iU2qbqv