Skip to content
This repository was archived by the owner on May 7, 2024. It is now read-only.

Auto save on closing page and removed save button#2

Open
Amanse wants to merge 1 commit into
MaxMoffa:masterfrom
Amanse:master
Open

Auto save on closing page and removed save button#2
Amanse wants to merge 1 commit into
MaxMoffa:masterfrom
Amanse:master

Conversation

@Amanse
Copy link
Copy Markdown

@Amanse Amanse commented Apr 6, 2020

Fixes #1
Auto saves entry on saving instead of having to hit the save button. Save button is also removed as there were double entries. Now to save just close the tab or press back as people are habitual on android for that especially when when we use add to homescreen to use it as an app.

Copy link
Copy Markdown
Owner

@MaxMoffa MaxMoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amanse! Thanks for your contribution. I think you are right there should be auto save although your code has some problems:

  1. Whene I press the arrow (on the top left corner) or I click the back button on the smartphone, the app closes itself automatically instead of going back to the home
  2. Please don't change the style or the syntax of the instructions, I don't know if it was you or a plugin you use on your code editor

Thanks again for your contribution 💪

  • Massimo Moffa

@Amanse
Copy link
Copy Markdown
Author

Amanse commented Apr 6, 2020

I was planning to make a single change but unfortunately my browser cached the page so even if i shutdown the local server it would still show, so i kept making changes and maybe screwed a few things on the way... Sorry about that... And prettier did the other
I'm pretty new to this stuff, sorry about the inconvenience and thanks for making such an app!

@MaxMoffa
Copy link
Copy Markdown
Owner

MaxMoffa commented Apr 6, 2020

This type of app is called PWA (Progressive Web App) and the core is the Service Worker which is a particular js file which contains various directives such as the files to cache. In order to avoid this type of problems while working on this project you have to disable the service worker or at least you have to unregister his scope

How to unregister service workers

@Amanse
Copy link
Copy Markdown
Author

Amanse commented Apr 7, 2020

That's very helpful, thanks a lot!
You are a very reactive developer, or should i say seveltive cuz it's much lighter and better?
Bad pun, but still, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto save on closing creator page(enhancement)

2 participants