Remove general budgeting ledger functionality#49
Conversation
- Deleted `TransactionEntity`, `TransactionMapper`, and `TransactionDao` to clean up the data layer. - Removed `TransactionRepository`, `AddTransactionUseCase`, `DeleteTransactionUseCase`, and `GetTransactionsUseCase` from the domain layer. - Deleted `TransactionsScreen` and `TransactionsViewModel` from the presentation layer. - Cleaned up Koin configurations (`AppModule.kt`) by removing unused module injections. - Removed unused general transaction entities from Room configuration (`AppDatabase.kt`). - Dropped unused `Transactions` and `AddTransaction` from `NavRoutes.kt`. - Left investment-related `HoldingTransaction` entirely intact. Co-authored-by: Max97k <14903047+Max97k@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the transactions feature from the application, including its database entities, DAOs, repositories, use cases, view models, and UI screens. Feedback was provided regarding the database configuration in AppDatabase.kt, where removing TransactionEntity requires incrementing the database version to 3 to prevent an IllegalStateException crash on startup for existing users.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| @Database( | ||
| entities = [TransactionEntity::class, HoldingEntity::class, HoldingTransactionEntity::class], | ||
| entities = [HoldingEntity::class, HoldingTransactionEntity::class], |
There was a problem hiding this comment.
Since TransactionEntity has been removed from the database entities, the database schema has changed. If the database version is kept at 2, Room will throw an IllegalStateException on startup for existing users because the schema on disk won't match the compiled schema. To prevent this crash and allow fallbackToDestructiveMigration() to recreate the database, please increment the database version to 3 (on line 11).
1 participant
Removes the unused and hidden general ledger/transactions functionality to trim bloat and focus entirely on the investment portfolio domain. Ensures local DB configurations, DI, domain layer, and UI screens are completely pruned of any references to the standard budgeting transaction elements.
PR created automatically by Jules for task 3351300500818310939 started by @Max97k