Promote overflow tasks and add side conversation - #2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e512070c86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR enhances Joydex’s task-alert slot management by introducing delayed backfill promotion from overflow into newly vacated primary slots (with queue compaction), and adds a new “side conversation” action wired to Codex’s openSideChat command, along with updated Codex compatibility documentation.
Changes:
- Added a 5-second backfill delay that reserves vacated primary slots, then promotes the earliest overflow task and compacts the overflow queue.
- Ensured restored task-alert state fills primary holes immediately and compacts remaining overflow assignments.
- Added
side-conversation/CodexAction.SideConversationmapped to theopenSideChatCodex command, and updated compatibility versions/documentation.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Joydex.Tests/TaskAlertPoolTests.cs | Adds coverage for delayed overflow promotion, reservation behavior, and restore compaction. |
| tests/Joydex.Tests/CodexActionExecutorTests.cs | Extends action-to-command mapping expectations to include SideConversation. |
| src/Joydex.Windows/TaskAlerts/TaskAlertCoordinator.cs | Passes an explicit acknowledgement timestamp into the pool for backfill scheduling. |
| src/Joydex.Windows/Actions/CodexCommandCatalog.cs | Adds openSideChat command descriptor for the new SideConversation action. |
| src/Joydex.Core/TaskAlerts/TaskAlertPool.cs | Implements backfill reservations, delayed promotion, and overflow compaction logic. |
| src/Joydex.Core/Mapping/CodexAction.cs | Adds SideConversation enum value and parses side-conversation binding ID. |
| src/Joydex.App/ButtonMapForm.cs | Adds UI label for the side-conversation action. |
| docs/LED_STATUS.md | Updates user-facing behavior documentation to reflect primary/overflow behavior and delayed promotion. |
| CHANGELOG.md | Records the new overflow promotion behavior. |
| AGENTS.md | Updates the documented Codex compatibility validation date and version/build identifiers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
side-conversationJoydex action mapped to Codex's validatedopenSideChatcommandWhy
The overflow promotion and Side Conversation support were working-tree changes that were intentionally kept out of the wireless touchscreen PR. This PR preserves them as focused host changes after that PR was merged.
Validation
361Joydex tests and29wireless-panel tests)git diff --check: passedManual validation still pending
Notes
Backfill reservations are intentionally transient: after a restart, restored state fills primary holes immediately and compacts the remaining overflow queue.
openSideChathas no built-in fallback keystroke and therefore relies on the validated local Codex binding; unresolved bindings continue to fail closed through existing diagnostics.The separate
tools/Joydex.AgentActivity.Prototypework is excluded from this branch and PR.