Bump to 0.6.2 and harden Responses attachment/WebSocket behavior - #49
Open
Mattie wants to merge 2 commits into
Open
Bump to 0.6.2 and harden Responses attachment/WebSocket behavior#49Mattie wants to merge 2 commits into
Mattie wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pathentries were being flattened/omitted in the Responses WebSocket request shape, breaking live Phase 3 attachment flows.socket_receive_failed/stream_ended_before_response_completed) could abort otherwise-retryable requests too eagerly and reduce runtime resilience.Description
0.6.2by updatingpyproject.toml.input_textpart for conversational roles inResponsesNormalizationMixin._message_to_input_itemsso attachment-only turns preserve an explicit (possibly-empty) text item (chatsnack/runtime/responses_common.py)._MAX_REOPEN_RETRIES = 2and reopen attempt counters) so retriable transport errors can be recovered when no partial output has been emitted (chatsnack/runtime/responses_websocket_adapter.py).input_text+input_file) intests/runtime/test_responses_websocket_adapter.py.Testing
PYTHONPATH=. pytest -q tests/runtime/test_responses_websocket_adapter.py tests/test_phase3_runtime.py tests/test_phase2_sessions.py tests/mixins/test_query_attachments.pyand observed112 passed(suite passed).PYTHONPATH=. pytest -q tests/test_chatsnack_pattern.py tests/test_file_snack_fillings.pyand observed live-provider failures (3 tests) due to provider/model access errors (openai.NotFoundError: model 'gpt-4-turbo' not found), which are external to the changes and indicate the environment/API key does not have access to that model.Codex Task