Skip to content

feat(controls): added half page scroll up and down#90

Merged
MattiaPun merged 2 commits into
MattiaPun:mainfrom
suzana2314:feat-scroll-keybinds
Mar 19, 2026
Merged

feat(controls): added half page scroll up and down#90
MattiaPun merged 2 commits into
MattiaPun:mainfrom
suzana2314:feat-scroll-keybinds

Conversation

@suzana2314
Copy link
Copy Markdown
Contributor

Added half page scroll up and down navigation, mimicking Vim's Ctrl+U and Ctrl+D behaviour.

These keybinds can be changed in the config under keybinds.navigation.scroll_up and keybinds.navigation.scroll_down respectively.

I just reused the logic that was already there for standard navigation but added a new steps arg.

Let me know if there is anything wrong!

Copy link
Copy Markdown
Owner

@MattiaPun MattiaPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, good PR so far, just update the naming and add the keybinds to the helpViewContent function in view.go. Please let me know if you have any questions.

Comment thread internal/api/config.go
Comment thread internal/api/config.toml
@suzana2314
Copy link
Copy Markdown
Contributor Author

Hi, good PR so far, just update the naming and add the keybinds to the helpViewContent function in view.go. Please let me know if you have any questions.

Hey thanks for the heads up.

In case of the help view text would it be alright to be Go half page up to keep it consistent with the other navigation descriptions or do you prefer just Scroll half page up

For the config I renamed it to: scroll_half_page_up is this alright?

@MattiaPun
Copy link
Copy Markdown
Owner

Yes, the Go half page up is good, and make that for the config go_half_page_up as well, so change the scroll -> go.

@suzana2314 suzana2314 requested a review from MattiaPun March 19, 2026 10:57
@MattiaPun MattiaPun merged commit bae238a into MattiaPun:main Mar 19, 2026
1 check passed
@MattiaPun
Copy link
Copy Markdown
Owner

Thank you for your contribution!

@suzana2314 suzana2314 deleted the feat-scroll-keybinds branch March 19, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants