fix(scrobble): send now playing status for next song in queue#123
Merged
Conversation
Owner
|
Thank you for this fix, your contributions are really appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the queue advances to the next song, the "now playing" status was never sent to the server since that call only existed in the
PlaySongfunction. So it would only appear on the first song played from a queue, album, ... or when using the next or back song button.So I moved the now playing scrobble to the song change detection block in
handleStatus, so it fires on every song transition regardless of how the song changed. Also removed it from thePlaySongso it does not fire twice.Let me know what you think :)