feat: default volume configuration#114
Merged
Merged
Conversation
Owner
|
Hi Aaron, thank you for this PR. It will be available in the next release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
default_volumeoption to App section of config. Addresses #109Configuration Details
default_volume = -1(default): The player controls initial volume (current behavior). In my case mpv is persisting my previous session volume somehow, which I prefer over a set default.default_volume = 0-100: Sets a specific default volume on startup.default_volume > 100or< 0(except -1): Values are automatically clamped to the 0-100 range.Volume Adjustment Behavior
volumeStepif not already aligned (e.g., 43 goes up to 45, down to 40)Additional Notes
I noticed some redundancy between for example
mpvClient.CurrentVolumeandplayer.GetVolume, which could be considered in a future refactor / code cleanup.