fix(ui): cover art section is hidden on media player when disabled#110
Merged
MattiaPun merged 2 commits intoApr 18, 2026
Merged
Conversation
Owner
|
Hi, thank you for this PR. I have quickly added a fix for the indentation (when going from 9 to 10) and have changed it to the default queue numbering order (your latest overview). Thank you again for helping improve SubTUI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #108
Made it so the queue section extends till the bottom. Songs are filled dynamically depending on the height.
This is with the cover art enabled:

and disabled:

Let me know what you think :)
I will also use this pr to ask you something about this queue view.
Does the numbering make sense here? I ask you this because it's static. Take for example this queue:
The current song playing is
aaaaIn the media player (when an album art is shown) it will show like this:
Now song
aaaaended andbbbbis playing, it will show like this:so now
ccccis number 1, but wouldn't it make sense to be like this:keeping the default queue numbering order? Or just remove the numbering? What do you think?