Skip to content

fix(ui): cover art section is hidden on media player when disabled#110

Merged
MattiaPun merged 2 commits into
MattiaPun:mainfrom
suzana2314:fix-media-player-album-art-hidden-when-disabled
Apr 18, 2026
Merged

fix(ui): cover art section is hidden on media player when disabled#110
MattiaPun merged 2 commits into
MattiaPun:mainfrom
suzana2314:fix-media-player-album-art-hidden-when-disabled

Conversation

@suzana2314
Copy link
Copy Markdown
Contributor

Fixes: #108

Made it so the queue section extends till the bottom. Songs are filled dynamically depending on the height.

This is with the cover art enabled:
image

and disabled:
image

Let me know what you think :)

I will also use this pr to ask you something about this queue view.
Does the numbering make sense here? I ask you this because it's static. Take for example this queue:

aaaa
bbbb
cccc
dddd
eeee
ffff
gggg

The current song playing is aaaa
In the media player (when an album art is shown) it will show like this:

Next up
---
1. bbbb
2. cccc
3. dddd
4. eeee
5. ffff

Now song aaaa ended and bbbb is playing, it will show like this:

Next up
---
1. cccc
2. dddd
3. eeee
4. ffff
5. gggg

so now cccc is number 1, but wouldn't it make sense to be like this:

Next up
---
3. cccc
4. dddd
5. eeee
6. ffff
7. gggg

keeping the default queue numbering order? Or just remove the numbering? What do you think?

@MattiaPun MattiaPun merged commit c6a1f29 into MattiaPun:main Apr 18, 2026
1 check passed
@MattiaPun
Copy link
Copy Markdown
Owner

Hi, thank you for this PR. I have quickly added a fix for the indentation (when going from 9 to 10) and have changed it to the default queue numbering order (your latest overview).

Thank you again for helping improve SubTUI

@suzana2314 suzana2314 deleted the fix-media-player-album-art-hidden-when-disabled branch April 19, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Media Player menu incorrectly shows album cover when disabled in configuration.

2 participants