Collapse missing fixtures before parameter expansion - #1102
Merged
Conversation
MatthewMckee4
force-pushed
the
codex/issue-1088
branch
from
August 1, 2026 14:38
fcfc664 to
ac403fa
Compare
Contributor
✅ Merging this PR will not alter performanceAll benchmark scores
|
Contributor
⚡ Merging this PR reduces memory usageAll benchmark scores
|
Contributor
|
| Project | Previous | New |
|---|---|---|
requests |
❌ 149 pass · 0 fail · 6 error · 12 skip | ❌ 149 pass · 0 fail · 6 error · 12 skip |
fastapi |
❌ 1596 pass · 7 fail · 434 error · 1 skip | ❌ 1596 pass · 7 fail · 434 error · 1 skip |
httpx |
❌ 1022 pass · 50 fail · 54 error · 1 skip | ❌ 1022 pass · 50 fail · 51 error · 1 skip |
h11 |
✅ 78 pass · 0 fail · 0 error · 0 skip | ✅ 78 pass · 0 fail · 0 error · 0 skip |
markupsafe |
❌ 0 pass · 0 fail · 26 error · 0 skip | ❌ 0 pass · 0 fail · 26 error · 0 skip |
sniffio |
✅ 3 pass · 0 fail · 0 error · 1 skip | ✅ 3 pass · 0 fail · 0 error · 1 skip |
itsdangerous |
✅ 10 pass · 0 fail · 0 error · 0 skip | ✅ 10 pass · 0 fail · 0 error · 0 skip |
blinker |
✅ 25 pass · 0 fail · 0 error · 0 skip | ✅ 25 pass · 0 fail · 0 error · 0 skip |
jinja |
❌ 135 pass · 0 fail · 16 error · 0 skip | ❌ 135 pass · 0 fail · 16 error · 0 skip |
installer |
✅ 20 pass · 0 fail · 0 error · 0 skip | ✅ 20 pass · 0 fail · 0 error · 0 skip |
tomlkit |
✅ 332 pass · 0 fail · 0 error · 0 skip | ✅ 332 pass · 0 fail · 0 error · 0 skip |
outcome |
✅ 10 pass · 0 fail · 0 error · 0 skip | ✅ 10 pass · 0 fail · 0 error · 0 skip |
pluggy |
❌ 124 pass · 1 fail · 27 error · 0 skip | ❌ 124 pass · 1 fail · 11 error · 0 skip |
werkzeug |
❌ 728 pass · 3 fail · 0 error · 0 skip | ❌ 728 pass · 3 fail · 0 error · 0 skip |
httpx concise output diff
Durations and memory addresses are normalized.
--- main (ce8ff7d)
+++ PR (0d177fd)
@@ -38,8 +38,7 @@
PASS [TIME] tests.test_config::test_load_ssl_config_verify_existing_file
PASS [TIME] tests.test_config::test_load_ssl_config_verify_directory
ERROR [TIME] tests.test_config::test_load_ssl_config_cert_and_key
- ERROR [TIME] tests.test_config::test_load_ssl_config_cert_and_encrypted_key(password=b'password')
- ERROR [TIME] tests.test_config::test_load_ssl_config_cert_and_encrypted_key(password='password')
+ ERROR [TIME] tests.test_config::test_load_ssl_config_cert_and_encrypted_key
ERROR [TIME] tests.test_config::test_load_ssl_config_cert_and_key_invalid_password
ERROR [TIME] tests.test_config::test_load_ssl_config_cert_without_key_raises
PASS [TIME] tests.test_config::test_load_ssl_config_no_verify
@@ -157,8 +156,8 @@
PASS [TIME] tests.test_utils::test_guess_by_bom(encoding='utf-16-le', expected='utf-16')
PASS [TIME] tests.test_utils::test_guess_by_bom(encoding='utf-32-be', expected='utf-32')
PASS [TIME] tests.test_utils::test_guess_by_bom(encoding='utf-32-le', expected='utf-32')
- ERROR [TIME] tests.test_utils::test_logging_request(caplog)
- ERROR [TIME] tests.test_utils::test_logging_redirect_chain(caplog)
+ ERROR [TIME] tests.test_utils::test_logging_request
+ ERROR [TIME] tests.test_utils::test_logging_redirect_chain
PASS [TIME] tests.test_utils::test_get_environment_proxies(environment={}, proxies={})
PASS [TIME] tests.test_utils::test_get_environment_proxies(environment={'HTTP_PROXY': 'http://127...., proxies={'http://': 'http://127.0.0...)
PASS [TIME] tests.test_utils::test_get_environment_proxies(environment={'https_proxy': 'http://127..., proxies={'https://': 'http://127.0....)
@@ -197,9 +196,7 @@
PASS [TIME] tests.test_wsgi::test_wsgi_server_port(explicit-port)
PASS [TIME] tests.test_wsgi::test_wsgi_server_protocol
ERROR [TIME] tests.client.test_async_client::test_get
- ERROR [TIME] tests.client.test_async_client::test_get_invalid_url(scheme-not-http(s))
- ERROR [TIME] tests.client.test_async_client::test_get_invalid_url(no-scheme)
- ERROR [TIME] tests.client.test_async_client::test_get_invalid_url(no-host)
+ ERROR [TIME] tests.client.test_async_client::test_get_invalid_url
ERROR [TIME] tests.client.test_async_client::test_build_request
ERROR [TIME] tests.client.test_async_client::test_post
ERROR [TIME] tests.client.test_async_client::test_post_json
@@ -1153,9 +1150,7 @@
tests/client/test_async_client.py:12:11: error[missing-fixtures] Test `test_get` has missing fixtures: `server`
-tests.client.test_async_client::test_get_invalid_url(no-host):
-tests.client.test_async_client::test_get_invalid_url(no-scheme):
-tests.client.test_async_client::test_get_invalid_url(scheme-not-http(s)):
+tests.client.test_async_client::test_get_invalid_url:
tests/client/test_async_client.py:33:11: error[missing-fixtures] Test `test_get_invalid_url` has missing fixtures: `server`
@@ -1304,8 +1299,7 @@
tests/test_config.py:82:5: error[missing-fixtures] Test `test_SSLContext_with_get_request` has missing fixtures: `server`, `cert_pem_file`
-tests.test_config::test_load_ssl_config_cert_and_encrypted_key(password='password'):
-tests.test_config::test_load_ssl_config_cert_and_encrypted_key(password=b'password'):
+tests.test_config::test_load_ssl_config_cert_and_encrypted_key:
tests/test_config.py:51:5: error[missing-fixtures] Test `test_load_ssl_config_cert_and_encrypted_key` has missing fixtures: `cert_pem_file`, `cert_encrypted_private_key_...`
@@ -1393,11 +1387,11 @@
tests/test_utils.py:109:5: error[test-failure] Test `test_get_environment_proxies` failed
-tests.test_utils::test_logging_redirect_chain(caplog):
+tests.test_utils::test_logging_redirect_chain:
tests/test_utils.py:68:5: error[missing-fixtures] Test `test_logging_redirect_chain` has missing fixtures: `server`
-tests.test_utils::test_logging_request(caplog):
+tests.test_utils::test_logging_request:
tests/test_utils.py:53:5: error[missing-fixtures] Test `test_logging_request` has missing fixtures: `server`
@@ -1412,6 +1406,6 @@
error[failed-to-import-module] Failed to import python module `tests.test_decoders`: No module named 'chardet'
────────────
- Summary [TIME] 1127 tests run: 1022 passed, 50 failed, 54 errors, 1 skipped
+ Summary [TIME] 1124 tests run: 1022 passed, 50 failed, 51 errors, 1 skipped
stderr:pluggy concise output diff
Durations and memory addresses are normalized.
--- main (ce8ff7d)
+++ PR (0d177fd)
@@ -1,25 +1,9 @@
stdout:
Starting 122 tests across 1 worker
ERROR [TIME] testing.benchmark::test_hook_and_wrappers_speed
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=1, wrappers=1, nesting=0)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=1, wrappers=1, nesting=1)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=1, wrappers=1, nesting=5)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=1, wrappers=5, nesting=1)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=1, wrappers=5, nesting=5)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=5, wrappers=1, nesting=1)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=5, wrappers=1, nesting=5)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=5, wrappers=5, nesting=1)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=5, wrappers=5, nesting=5)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=20, wrappers=20, nesting=0)
- ERROR [TIME] testing.benchmark::test_call_hook(plugins=100, wrappers=100, nesting=0)
- ERROR [TIME] testing.benchmark::test_varnames(plain_function)
- ERROR [TIME] testing.benchmark::test_varnames(unbound_method)
- ERROR [TIME] testing.benchmark::test_varnames(bound_method)
- ERROR [TIME] testing.benchmark::test_varnames(class)
- ERROR [TIME] testing.benchmark::test_varnames_legacy(plain_function)
- ERROR [TIME] testing.benchmark::test_varnames_legacy(unbound_method)
- ERROR [TIME] testing.benchmark::test_varnames_legacy(bound_method)
- ERROR [TIME] testing.benchmark::test_varnames_legacy(class)
+ ERROR [TIME] testing.benchmark::test_call_hook
+ ERROR [TIME] testing.benchmark::test_varnames
+ ERROR [TIME] testing.benchmark::test_varnames_legacy
PASS [TIME] testing.test_details::test_parse_hookimpl_override
PASS [TIME] testing.test_details::test_warn_when_deprecated_specified(recwarn)
PASS [TIME] testing.test_details::test_warn_when_deprecated_args_specified(recwarn)
@@ -155,35 +139,19 @@
failures:
-testing.benchmark::test_call_hook(plugins=1, wrappers=1, nesting=0):
-testing.benchmark::test_call_hook(plugins=1, wrappers=1, nesting=1):
-testing.benchmark::test_call_hook(plugins=1, wrappers=1, nesting=5):
-testing.benchmark::test_call_hook(plugins=1, wrappers=5, nesting=1):
-testing.benchmark::test_call_hook(plugins=1, wrappers=5, nesting=5):
-testing.benchmark::test_call_hook(plugins=100, wrappers=100, nesting=0):
-testing.benchmark::test_call_hook(plugins=20, wrappers=20, nesting=0):
-testing.benchmark::test_call_hook(plugins=5, wrappers=1, nesting=1):
-testing.benchmark::test_call_hook(plugins=5, wrappers=1, nesting=5):
-testing.benchmark::test_call_hook(plugins=5, wrappers=5, nesting=1):
-testing.benchmark::test_call_hook(plugins=5, wrappers=5, nesting=5):
+testing.benchmark::test_call_hook:
testing/benchmark.py:132:5: error[missing-fixtures] Test `test_call_hook` has missing fixtures: `benchmark`
testing.benchmark::test_hook_and_wrappers_speed:
-testing/benchmark.py:93:5: error[missing-fixtures] Fixture `hooks` has missing fixtures: `request`
+testing/benchmark.py:102:5: error[missing-fixtures] Test `test_hook_and_wrappers_speed` has missing fixtures: `benchmark`
-testing.benchmark::test_varnames(bound_method):
-testing.benchmark::test_varnames(class):
-testing.benchmark::test_varnames(plain_function):
-testing.benchmark::test_varnames(unbound_method):
+testing.benchmark::test_varnames:
testing/benchmark.py:191:5: error[missing-fixtures] Test `test_varnames` has missing fixtures: `benchmark`
-testing.benchmark::test_varnames_legacy(bound_method):
-testing.benchmark::test_varnames_legacy(class):
-testing.benchmark::test_varnames_legacy(plain_function):
-testing.benchmark::test_varnames_legacy(unbound_method):
+testing.benchmark::test_varnames_legacy:
testing/benchmark.py:196:5: error[missing-fixtures] Test `test_varnames_legacy` has missing fixtures: `benchmark`
@@ -202,6 +170,6 @@
testing/conftest.py:11:5: error[missing-fixtures] Fixture `he_pm` has missing fixtures: `request`
────────────
- Summary [TIME] 152 tests run: 124 passed, 1 failed, 27 errors, 0 skipped
+ Summary [TIME] 136 tests run: 124 passed, 1 failed, 11 errors, 0 skipped
stderr:
MatthewMckee4
force-pushed
the
codex/issue-1088
branch
from
August 1, 2026 17:38
ac403fa to
0d177fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve missing test fixtures before generating parametrized variants, so unavailable plugin fixtures and typos produce one diagnostic for the base test instead of one error per case. Closes #1088.
Test Plan
Focused fixture and parametrization integration tests;
uvx prek run -a.