Reject stdin reads while output is captured - #1037
Draft
MatthewMckee4 wants to merge 1 commit into
Draft
Conversation
Contributor
❌ Merging this PR may alter performanceBaseline: ⚡ 0 improved benchmarks Warning Benchmark regressions were detected. Review the wall-time changes before merging. Performance Changes
All benchmark scores
|
Contributor
✅ Merging this PR will not alter memory usageAll benchmark scores
|
Contributor
✅ No diagnostic changesTest result comparison
|
MatthewMckee4
force-pushed
the
fix/captured-stdin
branch
from
July 26, 2026 16:26
b38befa to
295bdc7
Compare
MatthewMckee4
marked this pull request as draft
July 26, 2026 16:26
MatthewMckee4
force-pushed
the
fix/captured-stdin
branch
from
July 30, 2026 13:58
295bdc7 to
a5dc0b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject Python stdin reads with an actionable error while output capture is active, and redirect file descriptor 0 to immediate EOF for child processes. Preserve real stdin under
--no-capture. Closes #983.Test Plan
Ran
just testanduvx prek run -a.