feat(seo): apply full favicon set with sharp SVG icon#7
Merged
Conversation
Deploying caveviewer with
|
| Latest commit: |
c78e03c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a5edb69.caveviewer.pages.dev |
| Branch Preview URL: | https://feat-favicon-set.caveviewer.pages.dev |
Replace the two-PNG favicon setup with a complete icon package: SVG (preferred for sharp, scalable rendering), .ico and PNG fallbacks, an apple-touch-icon, Android Chrome icons, and a web manifest with theme colour. Drops the now-unreferenced favicon.png. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MattNotarangelo
force-pushed
the
feat/favicon-set
branch
from
a8ba3ba to
c78e03c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
favicon.png,favicon-96x96.png). This gives blurry icons at non-native sizes and no coverage for Apple touch icons, Android home-screen icons, or PWA install metadata.What Has Changed
public/:favicon.svg,favicon.ico,favicon-48x48.png,favicon-96x96.png,apple-touch-icon.png,android-chrome-192x192.png,android-chrome-512x512.png, andsite.webmanifest.<head>icon block inindex.htmlto declare the SVG first (type="image/svg+xml") so capable browsers render the crisp scalable icon, with.ico/PNG fallbacks, the apple-touch-icon, the manifest link, and atheme-colormeta (#121a28).public/favicon.png.Notes
img-src 'self'covers the icons andmanifest-srcfalls back todefault-src 'self'.site.webmanifestuses root-absolute icon paths, correct for serving at the root ofcaveviewer.pages.dev.Screenshots/Video
Checklist
Verification
npm run build(tsc + vite) passes clean; all 8 assets emit todist/and Vite rewrites references to relative paths perbase: "./".