Dharok set effect#121
Open
Sacca-1 wants to merge 2 commits into
Open
Conversation
Apply Dharok scaling to live attacks using exact local HP or the latest visible or estimated opponent HP. - Detect complete normal, degraded, and LMS sets while excluding broken pieces. - Persist attack-time opponent HP locally and show it in the detailed-log heart field. - Keep the local aH field out of PvP-Hub upload payloads. - Cover set detection, scaling, HP formatting, legacy JSON, and upload compatibility.
Rebuild logged Dharok attacks using the exact HP snapshots supplied by the merged fight. - Prefer synced attacker C.h and fighter b.h values over local estimates. - Update max hit, expected damage, and the fighter expected-damage aggregate. - Run reconciliation after both fresh and cached PvP-Hub sync responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
Finally got around to the Dharok set effect. It's mostly done as discussed, but since the PvP-Hub is now a thing, I figured I'd include recalculation when an exact HP value is synced after a fight.
The recalculation could also be done server-side, which is probably preferred if the goal is to keep the website fully up to date with the correct stats. I therefore split local recalculation into a separate commit, so it can be dropped if server-side makes more sense.
Also KO chance recalculation will need a similar path, but since that's more of a general thing than Dharok-specific (and would also probably be better server-side), I left it out of this PR for now.