Add update method to document controller - #329
Open
Creiwry wants to merge 16 commits into
Open
Conversation
…t category and filename
…d update documents
Mate2xo
requested changes
Jan 18, 2023
Mate2xo
left a comment
Mate2xo
left a comment
Owner
There was a problem hiding this comment.
I haven't finished yet, I'll make antother review later. Good work so far, thanks
Mate2xo
requested changes
Jan 22, 2023
Comment on lines
+3
to
+4
| document_name: File name | ||
| download_file: Download |
Owner
There was a problem hiding this comment.
ref the the previous .key.lookup comment before ;
download_file sould probably be under the index key
Mate2xo
requested changes
Feb 2, 2023
| params.require(:document).permit(:category, :file, :file_name) | ||
| end | ||
|
|
||
| def update_transaction # removed the equals thing here, don't know if it still works |
Owner
There was a problem hiding this comment.
This comment does not gives relevant information to the reader without context. It's better to delete it.
Btw, if you don't know if it still works, then you should write a test to check that.
Collaborator
Author
There was a problem hiding this comment.
Ooops, my bad. Made the comment for myself but forgot to delete
update the branch to be compatible with remote main branch
Mate2xo
approved these changes
Jun 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets: #315 and #316
Added features: