Potential fix for code scanning alert no. 3: Workflow does not contain permissions#3
Draft
MaryAndMoore wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 3: Workflow does not contain permissions#3MaryAndMoore wants to merge 1 commit into
MaryAndMoore wants to merge 1 commit into
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: MaryAndMoore <aryannedemoore@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/MaryAndMoore/cookbook/security/code-scanning/3
To fix this, explicitly restrict the
GITHUB_TOKENpermissions used by the workflow to the minimum required. Bothnbfmtandnblintonly need to read repository contents (foractions/checkoutandgit fetch); they do not need to write contents, manage issues, or access other scopes.The simplest, non-breaking fix is to add a top-level
permissionsblock in.github/workflows/notebooks.yaml(alongsidenameandon) withcontents: read. This will apply to all jobs in the workflow that do not override it, covering bothnbfmtandnblintwithout changing their steps. No additional imports, actions, or commands are needed.Concretely, in
.github/workflows/notebooks.yaml, after thename: Notebooksline, insert:Leave the rest of the file unchanged.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.