[codex] Fix Linux GTK build compatibility#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Linux GTK app build failure reported with newer GLib headers.
Root Cause
g_subprocess_launcher_set_environ()expects a mutablegchar **, butrun_subprocess()declaredenvpasconst gchar * const *. GCC rejects that incompatible pointer type when compilinglinux/LLMTranslateLinux/src/main.c.The same file also used
G_APPLICATION_FLAGS_NONE, which is deprecated in GLib 2.74+.Changes
run_subprocess()envpparameter togchar **to match GLib's API signature.G_APPLICATION_DEFAULT_FLAGSon GLib 2.74+ while keepingG_APPLICATION_FLAGS_NONEfor older GLib versions.Validation
git diff --check -- linux/LLMTranslateLinux/src/main.cbash -n install.sh linux/install-desktop.sh linux/llm-translate-linux bin/llm-translate lib/openai_compat.sh lib/stream.sh lib/providers/*.sh macos/LLMTranslateMac/scripts/build-app.shshellcheck bin/llm-translate install.sh linux/install-desktop.sh linux/llm-translate-linux lib/openai_compat.sh lib/stream.sh lib/providers/*.sh macos/LLMTranslateMac/scripts/build-app.shFull Linux GTK
makewas not run locally because this macOS environment does not havegtk+-3.0pkg-config development files installed.