[QMS-902] Improve HiDPI Support#1134
Open
jmlzr wants to merge 8 commits into
Open
Conversation
Collaborator
|
At least on old fashioned, normal screens everything is the same 😄 |
Rewrite CMapTMS::draw from scratch to be maintainable again and correctly handle tiles of different sizes other then 256px (like HiDPI tiles).
Contributor
Author
|
I now made VRT maps and DEMs load data at physical resolution, till now they used logical which would reduce quality for HiDPI screens.
Rendering of TMS tiles with size != 256px should look different for you as well! Confirmed with setting my screen to 1.0 scale. |
Take HiDPI scaling into account to read at the physical pixel resolution. Previously logical pixels were used resulting in a quality loss of DEM shadings on HiDPI screens.
Those changes have not been tested and were properly wrong.
The same information is available in IDrawContext::buffer_t::image using the devicePixelRatio method.
Same change as to CDemVRT which should behave identical in that regard.
Contributor
Author
|
Side note: Just noticed that some window sizes result in the VRT code choosing a buffer size 1 pixel smaller than the buffer from the drawing context which will possibly cause a scale at the end: |
Some HiDPI servers reuse a standard TileMatrixSet (e.g. TileWidth=256) while serving larger (e.g. 512px) tiles. Add layer_t::tileScale, learned from the first tile, and divide the candidate pixel span by it during selection so tiles land 1:1 on physical pixels.
Contributor
Author
|
WMTS should now be working as expected even with problematic servers. With that this PR is ready for review. |
Contributor
|
Just to note. I notice some compiler warnings in my dev environment. Some already exists quite a while but some are new and seems related to this PR: |
Contributor
Author
|
@kkarsten62 all preexisting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the linked issue for this pull request:
QMS-#902
What you have done:
Steps to perform a simple smoke test:
Open TMS and WMTS maps with various tile sizes.
Try a DEM and a VRT map.
Does the code comply to the coding rules and naming conventions Coding Guidelines:
Is every user facing string in a tr() macro?
Did you add the ticket number and title into the changelog? Keep the numeric order in each release block.