Blob binary transmission - #127
Draft
jonnyz32 wants to merge 57 commits into
Draft
Conversation
jonnyz32
commented
Aug 26, 2025
| final DataStreamProcessor io = new DataStreamProcessor(System.in, System.out, conn, testMode); | ||
|
|
||
| io.run(); | ||
| // final DataStreamProcessor io = new DataStreamProcessor(System.in, System.out, conn, testMode); |
Collaborator
Author
There was a problem hiding this comment.
Need to figure out what to do here since the binarySender is relying on having a websocket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary data received in form
|blobQueryId (2 bytes)| replacementIndex (1 byte) | blobLength (4 bytes) | blob (blobLength bytes)| replacementIndex (1 byte) | blobLength (4 bytes) | blob (blobLength bytes)| ...
binary data sent in form
|queryIdLength (1 byte) | queryId (queryIdLength bytes) (utf8) | rowId (4 bytes) | colNameLength (1 byte) | colName (colNameLength bytes) (utf8) | blobLength (4 bytes) | blob (blobLength bytes)|
The changes for the js client are here Mapepire-IBMi/mapepire-js#55
We will need similar changes for the other clients.
Note: We shouldn't merge this before getting the other clients ready because it does have breaking changes. Namely there is a rowId field that is sent back in blob requests that is used as metadata. The field needs to be deleted once the full response is assebled on the client side.