Retrieve Certificate from server for authentication - #10
Open
mwiltzius wants to merge 1 commit into
Open
Conversation
…ate from server Change DamonServer::ca to private and add getter
jwoehr
reviewed
Mar 6, 2026
jwoehr
left a comment
jwoehr
left a comment
Collaborator
There was a problem hiding this comment.
- I wonder about the logic of using a temp file for the cert without having any concrete reason to object to it
- Might consider using the editor to insert the argument names
In general LGTM
| 'capture_peer_cert' => true, | ||
| ]]); | ||
|
|
||
| $socket = @stream_socket_client("ssl://{$this->host}:{$this->port}", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create and use DaemonServer::retrieveCertificate() to obtain certificate from server
Change DamonServer::ca to private and add getter
These changes are meant to mirror the approach used in mapepire-python.