Skip to content
This repository was archived by the owner on Oct 7, 2025. It is now read-only.

Don't need dataclasses package anymore.#1301

Open
Boby360 wants to merge 1 commit into
Map-A-Droid:asyncfrom
Boby360:patch-1
Open

Don't need dataclasses package anymore.#1301
Boby360 wants to merge 1 commit into
Map-A-Droid:asyncfrom
Boby360:patch-1

Conversation

@Boby360

@Boby360 Boby360 commented Feb 12, 2023

Copy link
Copy Markdown
Contributor

From what I recall, this package was only needed prior to Python 3.7.
Ran my install without the package installed with no obvious related issues.

From what I recall, this package was only needed prior to Python 3.7.
@Grennith

Grennith commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

We do use dataclasses in multiple instances afaik.
E.g., https://github.com/Map-A-Droid/MAD/blob/async/mapadroid/updater/SubJob.py#L1
Guessing it has been integrated into python natively since...
"New in version 3.7."
https://docs.python.org/3/library/dataclasses.html

@Boby360

Boby360 commented Feb 25, 2023

Copy link
Copy Markdown
Contributor Author

That is what I meant to convey.
Yes, it is integrated natively now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants