fix: stabilize 2PC, idempotency hits, and mock bank integration#13
Merged
Conversation
MananVelani
commented
Apr 22, 2026
MananVelani
commented
Owner
- placeholder/main.go: add /charge route (workers POST to /charge, not /v1/payments)
- placeholder/main.go: return SUCCESS status so workers mark bank calls as successful
- payment-log/store.go: add PREPARED state validation before COMMIT/ROLLBACK
- proto/worker/worker.pb.go: add IdempotencyKey field + GetIdempotencyKey() to TaskResult
- coordinator/main.go: fix InFlight map to key by TaskId (was WorkerId)
- coordinator/main.go: retrieve idempotency key from InFlight before WriteResult to C4
- worker/internal/service/worker_impl.go: include IdempotencyKey in outbox TaskResult
- worker/internal/transport/grpc/client_c2.go: pass IdempotencyKey in ReportResult
- monitor/scraper/scraper.go: flexible prefix/substring metric label matching for tasks/min
- monitor/dashboard/static/index.html: frontend connected to backend WebSocket pipeline
- docker-compose.yml: updated service configs and environment variables
- placeholder/main.go: add /charge route (workers POST to /charge, not /v1/payments) - placeholder/main.go: return SUCCESS status so workers mark bank calls as successful - payment-log/store.go: add PREPARED state validation before COMMIT/ROLLBACK - proto/worker/worker.pb.go: add IdempotencyKey field + GetIdempotencyKey() to TaskResult - coordinator/main.go: fix InFlight map to key by TaskId (was WorkerId) - coordinator/main.go: retrieve idempotency key from InFlight before WriteResult to C4 - worker/internal/service/worker_impl.go: include IdempotencyKey in outbox TaskResult - worker/internal/transport/grpc/client_c2.go: pass IdempotencyKey in ReportResult - monitor/scraper/scraper.go: flexible prefix/substring metric label matching for tasks/min - monitor/dashboard/static/index.html: frontend connected to backend WebSocket pipeline - docker-compose.yml: updated service configs and environment variables
MananVelani
requested review from
IAMonlyParthGandhi,
NIKHIL-07-CYBER,
chatterjee-sid and
iamabhinav333
and removed request for
chatterjee-sid and
iamabhinav333
chatterjee-sid
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.