Skip to content

Dfuds implementation#46

Open
Sanya239 wants to merge 3 commits into
mainfrom
dfuds-implementation
Open

Dfuds implementation#46
Sanya239 wants to merge 3 commits into
mainfrom
dfuds-implementation

Conversation

@Sanya239
Copy link
Copy Markdown
Collaborator

No description provided.

@Sanya239 Sanya239 requested a review from Malkovsky May 14, 2026 22:35
Comment thread include/pixie/dfuds_tree.h Outdated
/**
* @brief Returns the size of the tree
*/
size_t size() const { return num_bits_ / 2; }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: size() returns an incorrect node count

num_bits_ is initialized as 2 * tree_size - 1, so num_bits_ / 2 evaluates to tree_size - 1 for all non-empty trees. This under-reports the actual tree size by one and can break callers relying on size() for bounds or traversal logic.

Comment thread scripts/coverage_report.sh Outdated
"${BUILD_DIR}/unittests"
"${BUILD_DIR}/excess_positions_tests"
"${BUILD_DIR}/louds_tree_tests"
"${BUILD_DIR}/dfus_tree_tests"

This comment was marked as outdated.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 14, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • include/pixie/dfuds_tree.h

Reviewed by gpt-5.3-codex · 123,918 tokens

@Sanya239 Sanya239 force-pushed the dfuds-implementation branch 2 times, most recently from a4a5921 to a6575a7 Compare May 14, 2026 22:52
@Sanya239 Sanya239 force-pushed the dfuds-implementation branch from a6575a7 to c447002 Compare May 14, 2026 23:03
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 98.52941% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.11%. Comparing base (a553366) to head (cf4782d).

Files with missing lines Patch % Lines
include/pixie/utils.h 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   87.29%   87.11%   -0.18%     
==========================================
  Files          12       14       +2     
  Lines        3117     3252     +135     
  Branches      612      626      +14     
==========================================
+ Hits         2721     2833     +112     
- Misses        260      263       +3     
- Partials      136      156      +20     
Flag Coverage Δ
gcov 87.11% <98.52%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant