Add searchable dropdown member selector#153
Open
JonLD wants to merge 9 commits into
Open
Conversation
Implements a compact, searchable dropdown for selecting members, replacing the basic number input on training forms. Features: - Search by name, member number, or email - Gravatar thumbnails in dropdown - Keyboard navigation (arrow keys, Enter, Escape) - Click-outside to close - Clear selection button Updates mark-member-trained and mark-member-trained-by forms to use the new component. Closes Makespace#143
- Move inline JS from separate file into member-selector.ts - Remove member-selector-js.ts (no longer needed) - Update forms to use simplified member selector - Change selection UX to highlight input instead of separate display
- Migrate revoke-member-trained-form to use memberSelector - Remove email from member data payload (privacy + smaller size) - Limit search results to 50 items - Fix duplicate initialization when multiple selectors on page - Delete unused member-input.ts and member-input-minimal.ts - Remove trailing blank line from CSS
Lan2u
approved these changes
Dec 21, 2025
Collaborator
Lan2u
left a comment
Lan2u
left a comment
There was a problem hiding this comment.
LGTM - Doing a bit of local testing before merging
Lan2u
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements what I think #143 wants
Test plan