Apply fixes suggested by Manu#2
Conversation
📝 WalkthroughWalkthroughEIP-1 governance documentation receives a comprehensive update: capitalization standardized across role references (EIP Author/Editor), EIP Types section reorganized with expanded Standards Track guidance, shepherding workflow clarified with explicit warnings on contentious issues, implementation platform requirements expanded, editor responsibilities restructured, and obsolete specification testing subsection removed. ChangesEIP-1 Governance and Process Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@EIPS/eip-1.md`:
- Line 102: Replace occurrences of "RFC 822" in the EIP header/preamble text
with "RFC 5322" (or "RFC 822 style (RFC 5322)" if you want the historical note)
— specifically update the string "Preamble - [RFC 822] style headers..." and the
other two places that reference RFC 822 (including the link reference) so they
point to or cite RFC 5322 as the current standard; ensure the link target and
display text reflect RFC 5322 accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| Each EIP should have the following parts: | ||
|
|
||
| - Preamble - RFC 822 style headers containing metadata about the EIP, including the EIP number, a short descriptive title (limited to a maximum of 44 characters), a description (limited to a maximum of 140 characters), and the author details. Irrespective of the category, the title and description should not include EIP number. See [below](./eip-1.md#eip-header-preamble) for details. | ||
| - Preamble - [RFC 822] style headers containing metadata about the EIP, including the EIP number, a short descriptive title (limited to a maximum of 44 characters), a description (limited to a maximum of 140 characters), and the author details. Irrespective of the category, the title and description should not include EIP number. See [below](./eip-1.md#eip-header-preamble) for details. |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the current RFC standard for email message format headers that obsoleted RFC 822?
💡 Result:
RFC 822 was originally superseded by RFC 2822, which was subsequently obsoleted by RFC 5322, Internet Message Format [1][2][3]. RFC 5322 is the current authoritative standard for the format of text messages sent between computer users, including email message headers [1].
Citations:
- 1: https://www.rfc-editor.org/rfc/rfc5322
- 2: https://www.rfc-editor.org/rfc/rfc2822.html
- 3: https://www.rfc-editor.org/info/rfc822
Update RFC 822 reference to RFC 5322.
RFC 822 was obsoleted by RFC 2822 and subsequently by RFC 5322 (October 2008), which is the current authoritative standard for Internet Message Format and email message headers. Update lines 102, 119, and the link reference at lines 583-584 to use RFC 5322 instead, or use "RFC 822 style (RFC 5322)" if historical terminology is intentional.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@EIPS/eip-1.md` at line 102, Replace occurrences of "RFC 822" in the EIP
header/preamble text with "RFC 5322" (or "RFC 822 style (RFC 5322)" if you want
the historical note) — specifically update the string "Preamble - [RFC 822]
style headers..." and the other two places that reference RFC 822 (including the
link reference) so they point to or cite RFC 5322 as the current standard;
ensure the link target and display text reflect RFC 5322 accordingly.
2 participants
ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS
--
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:
Summary by CodeRabbit