-
Notifications
You must be signed in to change notification settings - Fork 1
Restructure for Google Fonts onboarding #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Krivoblotsky
wants to merge
2
commits into
main
Choose a base branch
from
claude/amazing-cannon-339c2c
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: Build fonts | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.11" | ||
| cache: pip | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
|
|
||
| - name: Build with gftools | ||
| working-directory: sources | ||
| run: gftools builder config.yaml | ||
|
|
||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: fixel-fonts | ||
| path: fonts/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: FontBakery | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| fontbakery: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.11" | ||
| cache: pip | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
|
|
||
| - name: Build fonts | ||
| working-directory: sources | ||
| run: gftools builder config.yaml | ||
|
|
||
| - name: Run FontBakery on variable font | ||
| run: | | ||
| fontbakery check-googlefonts \ | ||
| --succinct \ | ||
| --full-lists \ | ||
| --html fontbakery-report-vf.html \ | ||
| fonts/variable/*.ttf | ||
| continue-on-error: true | ||
|
|
||
| - name: Run FontBakery on static TTFs | ||
| run: | | ||
| fontbakery check-googlefonts \ | ||
| --succinct \ | ||
| --full-lists \ | ||
| --html fontbakery-report-static.html \ | ||
| fonts/ttf/*.ttf | ||
| continue-on-error: true | ||
|
|
||
| - name: Upload FontBakery reports | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: fontbakery-reports | ||
| path: fontbakery-report-*.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,16 @@ | ||
| .DS_Store | ||
| venv | ||
| venv | ||
| .venv | ||
| __pycache__/ | ||
| *.pyc | ||
|
|
||
| # gftools-builder intermediates | ||
| sources/instance_ufos/ | ||
| sources/master_ufo/ | ||
| sources/build.ninja | ||
| sources/.ninja_log | ||
| .ninja_log | ||
|
|
||
| # FontBakery HTML reports (the .md summary is committed) | ||
| FONTBAKERY-REPORT.html | ||
| fontbakery-report-*.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # FontBakery report | ||
|
|
||
| This file summarises the current state of `fontbakery check-googlefonts` against | ||
| the gftools-built artefacts. The detailed HTML report lives in | ||
| [FONTBAKERY-REPORT.html](FONTBAKERY-REPORT.html). | ||
|
|
||
| To regenerate: | ||
|
|
||
| ```sh | ||
| fontbakery check-googlefonts --succinct \ | ||
| --html FONTBAKERY-REPORT.html \ | ||
| 'fonts/variable/Fixel[wdth,wght].ttf' \ | ||
| fonts/ttf/Fixel-*.ttf fonts/ttf/FixelText-*.ttf | ||
| ``` | ||
|
|
||
| ## Current status (initial onboarding build) | ||
|
|
||
| Across the variable font + 18 statics: | ||
|
|
||
| | Severity | Count | | ||
| |---|---| | ||
| | ERROR | 3 | | ||
| | FATAL | 0 | | ||
| | FAIL | 272 | | ||
| | WARN | 337 | | ||
| | PASS | 1507 | | ||
|
|
||
| The volume is large because the same failure repeats across 19 files. The | ||
| distinct categories are listed below; each must be triaged before the family | ||
| can be merged into `google/fonts`. | ||
|
|
||
| ## Distinct FAIL categories | ||
|
|
||
| These are upstream-sources issues that the type designers (see [AUTHORS.txt](AUTHORS.txt)) | ||
| need to address: | ||
|
|
||
| - **`googlefonts/vertical_metrics` / `family/win_ascent_and_descent` / `os2_metrics_match_hhea` / `linegaps`** — OS/2 and hhea metrics are inconsistent and don't follow Google Fonts' rules. Typically resolved by running `gftools fix-vertical-metrics` and committing the fixed values into the UFO `fontinfo.plist`. | ||
| - **`use_typo_metrics`** — OS/2 `fsSelection` bit 7 (USE_TYPO_METRICS) must be set. | ||
| - **`googlefonts/glyph_coverage`** — missing codepoints from the GF Latin Core glyph set. Designers must add the missing glyphs. | ||
| - **`googlefonts/glyphsets/shape_languages`** — language-shaping checks (via shaperglot) report failed languages. | ||
| - **`whitespace_glyphs`** — missing NBSP (U+00A0). | ||
| - **`case_mapping`** — some lowercase glyphs lack uppercase counterparts (or vice versa). | ||
| - **`base_has_width`** — base glyphs with zero advance width. | ||
| - **`legacy_accents`** — combining accent glyphs incorrectly marked as bases / with width. | ||
| - **`name/trailing_spaces`**, **`googlefonts/name/line_breaks`** — name-table records contain stray whitespace / newlines. | ||
| - **`googlefonts/license/OFL_copyright`**, **`googlefonts/name/license`** — copyright string and license name records need the GF-required format. | ||
| - **`googlefonts/canonical_filename`** — output filenames need to match the GF naming convention exactly (likely just renaming statics from `Fixel-*.ttf` / `FixelText-*.ttf` to `Fixel[wdth,wght].ttf` + a `static/` folder per GF v2 layout). | ||
| - **`googlefonts/STAT/axisregistry`** — STAT axis-value names must match Google's [axis registry](https://github.com/google/fonts/tree/main/axisregistry). Width values "Text" / "Display" probably need to be replaced by registry-approved labels. | ||
| - **`googlefonts/vendor_id`** — set a registered 4-character vendor ID in `OS/2` (currently `NONE`/blank). | ||
|
|
||
| ## Distinct WARN categories (lower priority) | ||
|
|
||
| - `interpolation_issues` — sources have masters that don't interpolate cleanly at all axis positions. | ||
| - `mandatory_avar_table` — variable font lacks an `avar` table; gftools can generate one. | ||
| - `overlapping_path_segments`, `outline_direction` — outline-cleanliness issues to fix in the UFOs. | ||
| - `googlefonts/article/images` — GF v3 prefers a long-form `ARTICLE.en_us.html` plus sample images; optional but recommended. | ||
| - `googlefonts/metadata/unreachable_subsetting` — some encoded glyphs aren't reachable by GF's subsetter. | ||
|
|
||
| ## Next steps | ||
|
|
||
| 1. Fix the upstream-sources issues above in the UFOs (type designers). | ||
| 2. Re-run `gftools builder sources/config.yaml` and this report. | ||
| 3. Iterate until FAILs drop to zero (WARNs may remain if justified). | ||
| 4. File the GF onboarding issue at <https://github.com/google/fonts/issues/new/choose>. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| # Fixel | ||
|
|
||
| Fixel font public repository. | ||
|
|
||
| <img src="documentation/image_1.png"> | ||
|
|
@@ -7,11 +8,54 @@ Fixel font public repository. | |
| <img src="documentation/image_4.png"> | ||
| <img src="documentation/image_5.png"> | ||
|
|
||
| * Fixel Font includes extended Latin and Cyrillic alphabets, covering over 40 languages. | ||
| * The font comes in both Text and Display width options, with nine weight options from Thin to Black. | ||
| * The font is a unique combination of geometric and humanist grotesques, with open letterforms, wide width, crisp edges, and low contrast. | ||
| * Fixel Font is suitable for a variety of content types and sizes, from headlines and logos to large volumes of text. | ||
| * Fixel Font includes alternate symbols. They are more plastic and stand out with higher dynamics and asymmetry. | ||
| * Fixel Font preserves the history of the unique Ukrainian graphic culture. Among Fixel’s alternate symbols is the «tryzub,» the seal-trident of Volodymyr the Great and part of the Ukrainian coat of arms. The Fixel’s «tryzub» was developed by the outstanding Ukrainian painter and graphic artist Nil Khasevych in 1949. | ||
| * The font is free and can be used in commercial and other types of projects. | ||
| ## About | ||
|
|
||
| Fixel is a contemporary sans-serif by MacPaw — a combination of geometric and humanist grotesques, with open letterforms, wide proportions, crisp edges, and low contrast. It is suitable for content from headlines and logos to long passages of text. | ||
|
|
||
| - Extended Latin and Cyrillic; 40+ languages | ||
| - Two widths: **Display** (`wdth=100`) and **Text** (`wdth=87.5`) | ||
| - Nine weights: Thin → Black (`wght=100`–`900`) | ||
| - One variable font with `wdth` + `wght` axes | ||
| - Alternate symbols, including the «tryzub» after Nil Khasevych (1949) | ||
| - Free for commercial and personal use under the SIL Open Font License v1.1 | ||
|
|
||
| ## Repository layout | ||
|
|
||
| ``` | ||
| sources/ UFO masters, .designspace and gftools-builder config | ||
| fonts/ Build output: variable, static TTF, and webfonts (WOFF2) | ||
| documentation/ DESCRIPTION.en_us.html and images | ||
| ``` | ||
|
|
||
| ## Building | ||
|
|
||
| ```sh | ||
| pip install -r requirements.txt | ||
| cd sources | ||
| gftools builder config.yaml | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we commit this file or is it local and should be mentioned in the .gitignore? |
||
| ``` | ||
|
|
||
| This produces: | ||
|
|
||
| - `fonts/variable/Fixel[wdth,wght].ttf` — the variable font | ||
| - `fonts/ttf/*.ttf` — 18 static instances | ||
| - `fonts/webfonts/*.woff2` — webfont versions | ||
|
|
||
| ## Quality checks | ||
|
|
||
| ```sh | ||
| fontbakery check-googlefonts --succinct \ | ||
| fonts/variable/*.ttf fonts/ttf/*.ttf | ||
| ``` | ||
|
|
||
| CI runs the build and FontBakery on every pull request — see `.github/workflows/`. | ||
|
|
||
| ## Designers | ||
|
|
||
| See [AUTHORS.txt](AUTHORS.txt) and [CONTRIBUTORS.txt](CONTRIBUTORS.txt). | ||
|
|
||
| To contribute, contact [Max Kukurudziak](mailto:max@macpaw.com). | ||
|
|
||
| ## License | ||
|
|
||
| Licensed under the SIL Open Font License v1.1 — see [OFL.txt](OFL.txt). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| <p>Fixel Font Description</p> | ||
| <p>Fixel is a contemporary sans-serif typeface family published by MacPaw. It combines geometric and humanist grotesque traditions, with open letterforms, wide proportions, crisp edges, and low contrast — making it equally legible at small text sizes and expressive at display scale.</p> | ||
|
|
||
| <p>To contribute to the project contact | ||
| <a href="mailto:max@macpaw.com">Max Kukurudziak</a>.</p> | ||
| <p>The family ships in two widths — Display and Text — each available in nine weights from Thin to Black. The Display width is the default; the Text width is a slightly narrower variant tuned for longer passages. Both widths are unified in a single variable font with Weight (100–900) and Width (87.5–100) axes. Fixel covers extended Latin and Cyrillic scripts, supporting more than 40 languages, and includes a set of alternate symbols designed for higher dynamism and asymmetry.</p> | ||
|
|
||
| <p>Among Fixel's alternate glyphs is the «tryzub», the seal-trident of Volodymyr the Great and a national symbol of Ukraine, drawn after the 1949 design by Ukrainian painter and graphic artist Nil Khasevych. Fixel is released under the SIL Open Font License v1.1 and is free for use in commercial and personal projects.</p> | ||
|
|
||
| <p>To contribute, visit the <a href="https://github.com/MacPaw/Fixel">Fixel GitHub repository</a> or contact <a href="mailto:max@macpaw.com">Max Kukurudziak</a>.</p> |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| <?xml version='1.0' encoding='UTF-8'?> | ||
| <designspace format="4.1"> | ||
| <axes> | ||
| <axis tag="wght" name="Weight" minimum="100" maximum="900" default="400"/> | ||
| <axis tag="wdth" name="Width" minimum="87.5" maximum="100" default="100"/> | ||
| </axes> | ||
| <sources> | ||
| <source filename="FixelDisplay-Thin.ufo" familyname="Fixel" stylename="Thin"> | ||
| <location><dimension name="Weight" xvalue="100"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelDisplay-ExtraLight.ufo" familyname="Fixel" stylename="ExtraLight"> | ||
| <location><dimension name="Weight" xvalue="200"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelDisplay-Light.ufo" familyname="Fixel" stylename="Light"> | ||
| <location><dimension name="Weight" xvalue="300"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelDisplay-Regular.ufo" familyname="Fixel" stylename="Regular"> | ||
| <location><dimension name="Weight" xvalue="400"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelDisplay-Medium.ufo" familyname="Fixel" stylename="Medium"> | ||
| <location><dimension name="Weight" xvalue="500"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelDisplay-SemiBold.ufo" familyname="Fixel" stylename="SemiBold"> | ||
| <location><dimension name="Weight" xvalue="600"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelDisplay-Bold.ufo" familyname="Fixel" stylename="Bold"> | ||
| <location><dimension name="Weight" xvalue="700"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelDisplay-ExtraBold.ufo" familyname="Fixel" stylename="ExtraBold"> | ||
| <location><dimension name="Weight" xvalue="800"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelDisplay-Black.ufo" familyname="Fixel" stylename="Black"> | ||
| <location><dimension name="Weight" xvalue="900"/> <dimension name="Width" xvalue="100"/></location> | ||
| </source> | ||
| <source filename="FixelText-Thin.ufo" familyname="Fixel Text" stylename="Thin"> | ||
| <location><dimension name="Weight" xvalue="100"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| <source filename="FixelText-ExtraLight.ufo" familyname="Fixel Text" stylename="ExtraLight"> | ||
| <location><dimension name="Weight" xvalue="200"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| <source filename="FixelText-Light.ufo" familyname="Fixel Text" stylename="Light"> | ||
| <location><dimension name="Weight" xvalue="300"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| <source filename="FixelText-Regular.ufo" familyname="Fixel Text" stylename="Regular"> | ||
| <location><dimension name="Weight" xvalue="400"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| <source filename="FixelText-Medium.ufo" familyname="Fixel Text" stylename="Medium"> | ||
| <location><dimension name="Weight" xvalue="500"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| <source filename="FixelText-SemiBold.ufo" familyname="Fixel Text" stylename="SemiBold"> | ||
| <location><dimension name="Weight" xvalue="600"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| <source filename="FixelText-Bold.ufo" familyname="Fixel Text" stylename="Bold"> | ||
| <location><dimension name="Weight" xvalue="700"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| <source filename="FixelText-ExtraBold.ufo" familyname="Fixel Text" stylename="ExtraBold"> | ||
| <location><dimension name="Weight" xvalue="800"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| <source filename="FixelText-Black.ufo" familyname="Fixel Text" stylename="Black"> | ||
| <location><dimension name="Weight" xvalue="900"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </source> | ||
| </sources> | ||
| <instances> | ||
| <instance familyname="Fixel" stylename="Thin" filename="instance_ufo/Fixel-Thin.ufo"> | ||
| <location><dimension name="Weight" xvalue="100"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel" stylename="ExtraLight" filename="instance_ufo/Fixel-ExtraLight.ufo"> | ||
| <location><dimension name="Weight" xvalue="200"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel" stylename="Light" filename="instance_ufo/Fixel-Light.ufo"> | ||
| <location><dimension name="Weight" xvalue="300"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel" stylename="Regular" filename="instance_ufo/Fixel-Regular.ufo"> | ||
| <location><dimension name="Weight" xvalue="400"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel" stylename="Medium" filename="instance_ufo/Fixel-Medium.ufo"> | ||
| <location><dimension name="Weight" xvalue="500"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel" stylename="SemiBold" filename="instance_ufo/Fixel-SemiBold.ufo"> | ||
| <location><dimension name="Weight" xvalue="600"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel" stylename="Bold" filename="instance_ufo/Fixel-Bold.ufo"> | ||
| <location><dimension name="Weight" xvalue="700"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel" stylename="ExtraBold" filename="instance_ufo/Fixel-ExtraBold.ufo"> | ||
| <location><dimension name="Weight" xvalue="800"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel" stylename="Black" filename="instance_ufo/Fixel-Black.ufo"> | ||
| <location><dimension name="Weight" xvalue="900"/> <dimension name="Width" xvalue="100"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="Thin" filename="instance_ufo/FixelText-Thin.ufo"> | ||
| <location><dimension name="Weight" xvalue="100"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="ExtraLight" filename="instance_ufo/FixelText-ExtraLight.ufo"> | ||
| <location><dimension name="Weight" xvalue="200"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="Light" filename="instance_ufo/FixelText-Light.ufo"> | ||
| <location><dimension name="Weight" xvalue="300"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="Regular" filename="instance_ufo/FixelText-Regular.ufo"> | ||
| <location><dimension name="Weight" xvalue="400"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="Medium" filename="instance_ufo/FixelText-Medium.ufo"> | ||
| <location><dimension name="Weight" xvalue="500"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="SemiBold" filename="instance_ufo/FixelText-SemiBold.ufo"> | ||
| <location><dimension name="Weight" xvalue="600"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="Bold" filename="instance_ufo/FixelText-Bold.ufo"> | ||
| <location><dimension name="Weight" xvalue="700"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="ExtraBold" filename="instance_ufo/FixelText-ExtraBold.ufo"> | ||
| <location><dimension name="Weight" xvalue="800"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| <instance familyname="Fixel Text" stylename="Black" filename="instance_ufo/FixelText-Black.ufo"> | ||
| <location><dimension name="Weight" xvalue="900"/> <dimension name="Width" xvalue="87.5"/></location> | ||
| </instance> | ||
| </instances> | ||
| </designspace> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have this file in the repo and even add it to
.gitignoreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we should regenerate. got it