feat(backend): update Sati by xtiannyeto · Pull Request #1436 · MTES-MCT/rapportnav2

xtiannyeto · 2026-06-25T07:55:05Z

Change Database structure, Model, entity
Add Monitor attributes
Implement SatiEntityMapper
getComputeSati use case which getSait or Create if is not iexisting
processAti save sati if changes

tristanrobert · 2026-06-25T07:55:22Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

github-actions · 2026-06-25T07:58:49Z

Coverage Report for frontend

Status	Category	Percentage	Covered / Total
🔵	Lines	65.27% (🎯 40%)	3094 / 4740
🔵	Statements	63.96% (🎯 40%)	3358 / 5250
🔵	Functions	55.48% (🎯 40%)	1072 / 1932
🔵	Branches	59.26% (🎯 40%)	1452 / 2450

File Coverage

No changed files found.

Generated in workflow #4544 for commit 73bfa04 by the Vitest Coverage Report Action

- Change Database structure, Model, entity - Add Monitor attributes - Implement SatiEntityMapper - getComputeSati use case which getSait or Create if is not iexisting - processAti save sati if changes

- update mapping attribute orphan - create a enable sati flag regarding the user service

lwih · 2026-06-26T13:55:33Z

+
+import fr.gouv.dgampa.rapportnav.infrastructure.api.bff.model.v2.sati.Contact
+
+data class SatiParty(


Je suis pas sûr de vraiment comprendre le sens de Party. C'est quoi le mot en francais ?

lwih · 2026-06-26T13:59:01Z

+    val createdAt: Instant? = null,
+    val updatedAt: Instant? = null


Les champs d'audit, en général, je les remonte pas côté domain. Ils ont pas vraiment de business logic.
Par contre, je les remonte du Model vers le Admin type quand on les gère depuis l'admin panel

lwih · 2026-06-26T14:01:23Z

        if (!action.actionType.toString().endsWith("_CONTROL")) return null
-        val sati = satiRepo.findByActionId(actionId = action.id.toString())
+        var sati = satiRepo.findByActionId(actionId = action.id.toString())
+        if (sati == null) sati = satiRepo.save(getNewSati(action = action))


ok donc là, tu créés une row (par action) si elle existe pas encore, c'est ça ?

lwih · 2026-06-26T14:02:24Z


-    @Column(name = "zipcode", nullable = true, length = 20)
-    val zipcode: String? = null,
+    @Column(name = "full_address", length = 400)


fullAddress à 400 ? J'ai du mal à savoir si c'est suffisant ou pas

lwih · 2026-06-26T14:03:45Z

+    @Column(name = "nationality", length = 16)
+    var nationality: String? = null,


Un countrycode alpha3 comme on utilise dans d'autres trucs, c'est pas suffisant ?

lwih · 2026-06-26T14:04:19Z

+    @Column(name = "agent_id", length = 255)
+    var agentId: Int? = null,


le "length" ici, tu peux enlever je pense

lwih · 2026-06-26T14:05:53Z

+    @CreatedDate
+    @Column(name = "created_at", nullable = true, updatable = false)
+    var createdAt: Instant? = null,
+
+    @LastModifiedDate
+    @Column(name = "updated_at", nullable = true)
+    var updatedAt: Instant? = null,


T'as aussi d'autres champs genre createdBy et updatedBy aussi si tu veux pour les audits

github-actions · 2026-06-26T14:21:24Z

Overall Project	79.03% `-1.65%`	❌
Files changed	74.59%	❌

File	Coverage
JPASatiRepository.kt	100%	🍏
SatiPartyEntity.kt	100%	🍏
AuthorityType.kt	100%	🍏
LogbookMessagePurpose.kt	100%	🍏
SatiEntityMapper.kt	98.44% `-1.56%`	🍏
MissionActionDataOutput.kt	97.9% `-0.16%`	🍏
MissionAction.kt	97.64% `-0.37%`	🍏
SatiJpeEntity.kt	97.44% `-2.56%`	🍏
SatiModelMapper.kt	96.13% `-3.87%`	🍏
SatiMapper.kt	95.79% `-4.21%`	🍏
ProcessSati.kt	95.35% `-4.65%`	❌
SatiVesselEntity.kt	94.29% `-5.71%`	🍏
SatiParty.kt	93.94% `-6.06%`	🍏
ControlResourceEntity.kt	93.83% `-6.17%`	🍏
AddressEntity.kt	93.65% `-6.35%`	🍏
MissionFishAction.kt	92.72%	🍏
ControlResource.kt	92.59% `-7.41%`	🍏
SatiInspectorEntity.kt	91.18% `-8.82%`	🍏
ContactEntity.kt	85.71% `-7.94%`	❌
SatiEntity.kt	76.92% `-23.08%`	❌
SatiModuleType.kt	71.19% `-28.81%`	❌
SatiModel.kt	67.78% `-28.45%`	❌
SatiVesselModel.kt	63.33% `-36.67%`	❌
SatiVessel.kt	50% `-50%`	❌
SatiInspector.kt	50% `-50%`	❌
SatiJpe.kt	50% `-50%`	❌
SatiInspectorModel.kt	47.17% `-52.83%`	❌
SatiPartyModel.kt	47.17% `-52.83%`	❌
GetComputeSati.kt	37.75% `-62.25%`	❌
AddressModel.kt	37.16% `-62.84%`	❌
ContactModel.kt	37.16% `-62.84%`	❌
EnableSati.kt	0%	❌

xtiannyeto linked an issue Jun 25, 2026 that may be closed by this pull request

Update backend regarding new form #1434

Open

5 tasks

xtiannyeto requested a review from lwih June 25, 2026 07:55

feat(backend): update Sati

13a93ea

- Change Database structure, Model, entity - Add Monitor attributes - Implement SatiEntityMapper - getComputeSati use case which getSait or Create if is not iexisting - processAti save sati if changes

xtiannyeto force-pushed the feature/1434-update-backend-regarding-new-form branch from 471fb79 to da4ac59 Compare June 25, 2026 08:29

fix(backend): test

cd98bbc

xtiannyeto force-pushed the feature/1434-update-backend-regarding-new-form branch from da4ac59 to cd98bbc Compare June 25, 2026 08:42

feat(backend): fix save issue

939db64

- update mapping attribute orphan - create a enable sati flag regarding the user service

xtiannyeto force-pushed the feature/1434-update-backend-regarding-new-form branch from 4397bc6 to ffa380a Compare June 26, 2026 13:44

lwih reviewed Jun 26, 2026

View reviewed changes

MTES-MCT deleted a comment from github-actions Bot Jun 26, 2026

fix(backend): test on save

73bfa04

xtiannyeto force-pushed the feature/1434-update-backend-regarding-new-form branch from ffa380a to 73bfa04 Compare June 26, 2026 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(backend): update Sati#1436

feat(backend): update Sati#1436
xtiannyeto wants to merge 4 commits into
mainfrom
feature/1434-update-backend-regarding-new-form

xtiannyeto commented Jun 25, 2026

Uh oh!

tristanrobert commented Jun 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

lwih Jun 26, 2026

Uh oh!

lwih Jun 26, 2026

Uh oh!

lwih Jun 26, 2026

Uh oh!

lwih Jun 26, 2026

Uh oh!

lwih Jun 26, 2026

Uh oh!

lwih Jun 26, 2026

Uh oh!

lwih Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		import fr.gouv.dgampa.rapportnav.infrastructure.api.bff.model.v2.sati.Contact

		data class SatiParty(

		val createdAt: Instant? = null,
		val updatedAt: Instant? = null

		@Column(name = "nationality", length = 16)
		var nationality: String? = null,

		@Column(name = "agent_id", length = 255)
		var agentId: Int? = null,

Uh oh!

Conversation

xtiannyeto commented Jun 25, 2026

Uh oh!

tristanrobert commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for frontend

Uh oh!

lwih Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

lwih Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

lwih Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

lwih Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

lwih Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

lwih Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

lwih Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tristanrobert commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading