Refactor mission crew#1107
Open
lwih wants to merge 1 commit into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
lwih
force-pushed
the
refactor-mission-crew
branch
from
104d112 to
859dc31
Compare
Contributor
lwih
force-pushed
the
refactor-mission-crew
branch
2 times, most recently
from
c224e35 to
829228b
Compare
lwih
force-pushed
the
refactor-mission-crew
branch
from
829228b to
c989e8b
Compare
lwih
force-pushed
the
refactor-mission-crew
branch
from
c989e8b to
49aad89
Compare
lwih
force-pushed
the
refactor-mission-crew
branch
2 times, most recently
from
612670e to
4872ee4
Compare
lwih
force-pushed
the
refactor-mission-crew
branch
4 times, most recently
from
c2d9097 to
ea2c567
Compare
lwih
force-pushed
the
refactor-mission-crew
branch
from
ea2c567 to
753e6ea
Compare
lwih
force-pushed
the
refactor-mission-crew
branch
3 times, most recently
from
01e9c3d to
1652f46
Compare
lwih
force-pushed
the
refactor-mission-crew
branch
3 times, most recently
from
1ee9656 to
8014c5b
Compare
Contributor
|
lwih
commented
Mar 2, 2026
Comment on lines
+24
to
+27
| var startDate: LocalDate? = null, | ||
|
|
||
| @Column(name = "end_date", nullable = true) | ||
| var endDate: LocalDate? = null, |
Collaborator
Author
There was a problem hiding this comment.
je me demande si je suis pas un peu trop souple sur les dates
| BEGIN | ||
| CREATE TABLE IF NOT EXISTS public.mission_crew_absence ( | ||
| id SERIAL PRIMARY KEY, | ||
| mission_crew_id INTEGER NOT NULL REFERENCES public.mission_crew(id) ON DELETE CASCADE, |
Collaborator
Author
There was a problem hiding this comment.
La table Absence est liée à la table MissionCrew avec un delete cascade.
En théorie, on ne delete pas de row de MissionCrew donc le delete cascade est pas si dangereux mais est ce que pour des soucis d'archivage, il faudrait pas mieux virer le delete cascade ? T'as un avis ?
Comment on lines
+5
to
+11
| export function useMissionDates(missionId?: string): [string | undefined, string | undefined] { | ||
| const queryClient = useQueryClient() | ||
|
|
||
| const mission: Mission2 | undefined = missionId ? queryClient.getQueryData(missionsKeys.byId(missionId)) : undefined | ||
|
|
||
| return [mission?.data?.startDateTimeUtc, mission?.data?.endDateTimeUtc] | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Ici dans le frontend, après avoir déjà codé ce fichier, j'ai vu que t'as un use-mission avec quelques utils dedans. T'as un avis entre laisser ce hook ou le migrer dans use-mission ?
Collaborator
There was a problem hiding this comment.
on peut merger plus tard
Comment on lines
+43
to
+52
| // if a temporary absence matches the whole length of the mission | ||
| // set it as full mission absence instead of just temporary | ||
| const isAbsentFullMission = | ||
| value.isAbsentFullMission || | ||
| (missionStartDateTimeUtc && | ||
| missionEndDateTimeUtc && | ||
| startDate && | ||
| endDate && | ||
| isSameDay(new Date(startDate), new Date(missionStartDateTimeUtc)) && | ||
| isSameDay(new Date(endDate), new Date(missionEndDateTimeUtc))) |
Collaborator
Author
There was a problem hiding this comment.
ça, ça pourrait être fait dans le backend aussi
| fieldArray: FieldArrayRenderProps | ||
| } | ||
|
|
||
| const MissionGeneralInformationCrewPam: React.FC<MissionGeneralInformationCrewPamProps> = ({ |
Collaborator
Author
There was a problem hiding this comment.
Ce fichier il a pas vraiment changé mais au lieu d'un move, git m'a fait un delete/create
Comment on lines
+37
to
+47
| // Local state for "new/unsaved" temporary absences | ||
| // Initialize with one empty absence so the user sees a form immediately | ||
| const [localAbsences, setLocalAbsences] = useState<MissionCrewAbsence[]>(absences.length === 0 ? [EMPTY_ABSENCE] : []) | ||
|
|
||
| // Track validity and values for each form row | ||
| const formStatesRef = React.useRef<Record<number, FormState>>({}) | ||
| const [, forceUpdate] = useState(0) | ||
|
|
||
| // Display absences: committed ones first, then local ones | ||
| const displayAbsences = [...absences, ...localAbsences] | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
J'ai bien galéré avec Formik pour gérer des form temporaraires dans d'autres components dans des Modal
Comment on lines
+62
to
+67
| const allFormsValid = | ||
| displayAbsences.length > 0 && | ||
| displayAbsences.every((_, index) => { | ||
| const state = formStatesRef.current[index] | ||
| return state?.isValid === true | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
Pour disable le bouton "valider" dans la modal si une des form rows est pas valide
lwih
force-pushed
the
refactor-mission-crew
branch
3 times, most recently
from
82e9918 to
a3aba6f
Compare
lwih
force-pushed
the
refactor-mission-crew
branch
from
40dc21d to
543876a
Compare
xtiannyeto
approved these changes
Mar 9, 2026
| crewModel.agent = agent | ||
| } | ||
| // if (crew.agent != null && crew.agent.id != null) { | ||
| // val agent = dbAgentRepository.findById(crew.agent.id).orElseThrow() |
| DO | ||
| $$ | ||
| BEGIN | ||
| CREATE TABLE IF NOT EXISTS public.mission_crew_absence ( |
Collaborator
There was a problem hiding this comment.
naming, peut etre juste crew_absence
Comment on lines
+5
to
+11
| export function useMissionDates(missionId?: string): [string | undefined, string | undefined] { | ||
| const queryClient = useQueryClient() | ||
|
|
||
| const mission: Mission2 | undefined = missionId ? queryClient.getQueryData(missionsKeys.byId(missionId)) : undefined | ||
|
|
||
| return [mission?.data?.startDateTimeUtc, mission?.data?.endDateTimeUtc] | ||
| } |
Collaborator
There was a problem hiding this comment.
on peut merger plus tard
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.