Revert dspace oai harvesting to list method#342
Merged
Conversation
Why these changes are being introduced: As we update to DSpace CRIS (8), running some test harvests and revisiting dspace OAI harvesting configurations. We were using `--method=get`, but it appears this is no longer needed. Doubly so given that we are not providing any records to skip, which relied on that method. By removing `--method=...`, we default to `list` approach, which is orders of magnitude faster and more efficient to DSpace server. How this addresses that need: * Removes `dspace` from list of sources that should get `--method=get` passed for OAI harvester CLI command. Side effects of this change: * DSpace will no longer harvest via `ListIdentifiers` + `GetRecord` but will instead default to `ListRecords`. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-627
jonavellecuerdo
approved these changes
May 12, 2026
ehanson8
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Why these changes are being introduced:
As we update to DSpace CRIS (8), running some test harvests and revisiting dspace OAI harvesting configurations. We were using
--method=get, but it appears this is no longer needed. Doubly so given that we are not providing any records to skip, which relied on that method.By removing
--method=..., we default tolistapproach, which is orders of magnitude faster and more efficient to DSpace server.How this addresses that need:
dspacefrom list of sources that should get--method=getpassed for OAI harvester CLI command.Note: we currently have daily
dspaceruns in TIMDEX paused during the migration. While I have confirmed that the default--method=listmethod does in fact work for DSpace 6, it's ultimately moot. This will not get run fordspaceuntil we start our daily harvests again.How can a reviewer manually see the effects of these changes?
1- Build AWS SAM
Note: follow these instructions if having any issues getting SAM to run.
2- Invoke with payload:
Response (formatted):
{ "next-step": "transform", "run-date": "2026-05-12", "run-type": "full", "run-id": "92bd59b4-2d24-4e3c-a147-0e3bacccaf59", "source": "dspace", "verbose": true, "harvester-type": "oai", "extract": { "extract-command": [ "--verbose", "--host=https://mit.dspace.not.real/oai", "--output-file=s3://timdex-bucket/dspace/dspace-2026-05-12-full-extracted-records-to-index.xml", "harvest", "--metadata-format=mets", "--exclude-deleted" ] } }Note that
--method=getis not present in the OAI harvester CLI command, where it was formerly.Includes new or updated dependencies?
YES
Changes expectations for external applications?
YES: DSpace will no longer harvest via
ListIdentifiers+GetRecordbut will instead default toListRecords.What are the relevant tickets?
Code review