USE 111 - Initial app setup#8
Merged
Merged
Conversation
How this addresses that need: The root module will be called 'embeddings', and the entrypoint executable will be called 'embeddings'. Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-111
Why these changes are being introduced: When a .aws-architecture file is present, docker builds should use this architecture. This will come organically when we get into AWS ECR builds, but this application also includes a convenience 'make docker-build' that should utilize it too. How this addresses that need: * Adds 'CPU_ARCH' env var to top of Makefile Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-111
jonavellecuerdo
left a comment
Contributor
There was a problem hiding this comment.
It's looking good to me, however, one thing I noticed is that the Docker file uses Python 3.13. I'm assuming this is because that's what's in the template, but .python-version still reads 3.12. Can you verify which version of Python will be used?
Collaborator
Author
Nice catch!! Thank you. Should be 3.12 all around. Dockerfile is updated. |
jonavellecuerdo
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
This PR is the initial application setup, including:
my_apptoembeddingsREADMEembeddingsThis app is built from the
uvbranch inpython-cli-template. That branch had a recent update which this new repository inherits.As discussed internally, we had decided that new CLI applications would likely use
uv. Additionally, this application will have fairly significant library and technical requirements, makinguva good choice.This application also includes a
.aws-architecturefile with the valuelinux/arm64, which will build anarm64image/container once we get to deployment. This file is utilized in theMakefileto build the appropriate image type for the convenience commandmake docker-build.How can a reviewer manually see the effects of these changes?
Clone the repo and then run
make install.Then, confirm
make testandmake lintpass.Additionally, you can build a docker image and launch a container to test that side of things:
Output:
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review