Skip to content

Pin duckdb version in pyproject.toml for uv builds#172

Merged
ghukill merged 1 commit into
mainfrom
hotfix-pin-duckdb-v1-3-2
Sep 17, 2025
Merged

Pin duckdb version in pyproject.toml for uv builds#172
ghukill merged 1 commit into
mainfrom
hotfix-pin-duckdb-v1-3-2

Conversation

@ghukill

@ghukill ghukill commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Purpose and background context

Most TIMDEX components use pipenv to install TDA. But for applications that use uv, e.g. Marimo notebooks, we need to also pin duckdb in the pyproject.toml file.

Note: TDA is fairly unique for us as an installable python library. These kind of awkward edges will likely smooth out as we transition fully to uv.

Update: it's possible that both pipenv and uv use the pyproject.toml file for dependencies when installing TDA from github. Either way, it's confirmed that updating pyproject.toml with the duckdb pinning ensures we get the right version when TDA is installed.

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

  • None

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17802085551

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.011%

Totals Coverage Status
Change from base Build 17801699567: 0.0%
Covered Lines: 519
Relevant Lines: 558

💛 - Coveralls

@ghukill ghukill marked this pull request as ready for review September 17, 2025 15:12
@ghukill ghukill requested a review from a team September 17, 2025 15:12
@ghukill ghukill merged commit d173474 into main Sep 17, 2025
2 checks passed
@ghukill ghukill deleted the hotfix-pin-duckdb-v1-3-2 branch April 6, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants