Pin duckdb version in pyproject.toml for uv builds#172
Merged
Conversation
Pull Request Test Coverage Report for Build 17802085551Details
💛 - Coveralls |
ehanson8
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Most TIMDEX components use
pipenvto install TDA. But for applications that useuv, e.g. Marimo notebooks, we need to also pinduckdbin thepyproject.tomlfile.Note: TDA is fairly unique for us as an installable python library. These kind of awkward edges will likely smooth out as we transition fully to
uv.Update: it's possible that both
pipenvanduvuse thepyproject.tomlfile for dependencies when installing TDA from github. Either way, it's confirmed that updatingpyproject.tomlwith theduckdbpinning ensures we get the right version when TDA is installed.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?